fix: update wasm golden files for v0.25.14 and new actions permission#25003
Merged
lpcox merged 1 commit intocopilot/add-cli-proxy-feature-flagfrom Apr 7, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/45d7425a-e55e-4a76-8049-e58cad7ee0d6 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lpcox
April 7, 2026 02:44
View session
Copilot stopped work on behalf of
lpcox due to an error
April 7, 2026 02:44
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WASM compiler golden outputs to match the current generated workflow YAML, fixing failing TestWasmGolden_CompileFixtures subtests after an AWF version bump and a permissions change.
Changes:
- Regenerated
TestWasmGolden_CompileFixturesgolden files to reflect AWFv0.25.14(and corresponding image tags0.25.14). - Updated golden workflow permissions to include the newly generated
actions: readpermission on the activation job.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Updates expected compiled workflow output for version v0.25.14 and adds actions: read permission. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Updates expected compiled workflow output for version v0.25.14 and adds actions: read permission. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
lpcox
added a commit
that referenced
this pull request
Apr 7, 2026
…ll v0.25.14) (#24997) * Initial plan * feat: bump default AWF firewall version to v0.25.14 Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2e432b55-8a31-4eb8-ab16-7602b03acea2 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * feat: add cli-proxy and cli-proxy-writable feature flags with AWF command injection Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2e432b55-8a31-4eb8-ab16-7602b03acea2 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * feat: add awfSupportsCliProxy version gate to prevent failures on older AWF versions Agent-Logs-Url: https://github.com/github/gh-aw/sessions/180bd43e-792e-4d72-b6b0-137eacfdd829 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: update wasm golden files for v0.25.14 and new actions permission (#25003) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/45d7425a-e55e-4a76-8049-e58cad7ee0d6 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: resolve TypeScript errors in js workflow check (#25004) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d97ec115-fca7-468f-8455-80e276a712cf Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * ci: remove stale js-qmd-index job whose test file was deleted (#25005) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7417d3b0-97d5-4b8f-baf1-dff3635cd5d2 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: update assign_to_agent tests to use handler factory pattern (#25008) * fix: restore backward compat in assign_to_agent.cjs for standalone tests The main() function was refactored to a handler factory pattern but tests still use the old standalone interface (env vars + direct item processing). Add standalone mode detection when main() is called with no config: - Reads config from env vars (GH_AW_AGENT_DEFAULT, GH_AW_AGENT_MAX_COUNT, etc.) - Processes all assign_to_agent items from GH_AW_AGENT_OUTPUT - Writes summary, sets outputs, calls setFailed on errors Also fix the "Ignore-if-error mode enabled" log message to match tests. Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e00f51ce-33dd-493d-ba64-e13e1ebeb1be Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * fix: address code review feedback on standalone mode detection Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e00f51ce-33dd-493d-ba64-e13e1ebeb1be Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> * Update; rm -rf / Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * fix: update assign_to_agent tests to use handler factory pattern Replace `await main()` standalone calls in test evals with a STANDALONE_RUNNER snippet that simulates the safe-output handler manager flow: - build config from env vars - call main(config) to get the handler function - process assign_to_agent items through the handler - write summary, set outputs, call setFailed on errors Also fix the "encounters auth errors" assertion to match the production log message. No changes to assign_to_agent.cjs production code. Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d92459b5-9e9b-40ad-a0c6-108c70f23622 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing
build-wasmCI job (check run ID 70177114006).Root Cause
The
TestWasmGolden_CompileFixturestests (subtestsbasic-copilotandwith-imports) were failing because the golden files had stale expected output. Specifically:Version bump: The code now generates
v0.25.14(fromv0.25.13inpkg/constants/version_constants.go), but golden files still referencedv0.25.13in:GH_AW_INFO_AWF_VERSIONinstall_awf_binary.shinvocationdownload_docker_images.shcontainer image tags--image-tagAWF flagNew permission: A new
actions: readpermission is now generated for the activation job, which wasn't in the golden files.Fix
Regenerated the golden files using
make update-wasm-goldento match current compiler output.