Skip to content

ci: remove stale js-qmd-index job whose test file was deleted#25005

Merged
lpcox merged 1 commit intocopilot/add-cli-proxy-feature-flagfrom
copilot/fix-js-qmd-index-workflow
Apr 7, 2026
Merged

ci: remove stale js-qmd-index job whose test file was deleted#25005
lpcox merged 1 commit intocopilot/add-cli-proxy-feature-flagfrom
copilot/fix-js-qmd-index-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

Summary

The js-qmd-index CI job was failing because it tries to run qmd_index.test.cjs, which no longer exists.

Root Cause

The qmd_index.cjs and qmd_index.test.cjs files were deleted in #24855 ("fix: unknown tool names in frontmatter tools section are compile errors; remove qmd built-in"). However, the js-qmd-index CI job in .github/workflows/ci.yml that runs these tests was not cleaned up at the same time, causing CI to fail with:

No test files found, exiting with code 1
filter: qmd_index.test.cjs

Fix

Remove the stale js-qmd-index job from .github/workflows/ci.yml.

Fixes job: https://github.com/github/gh-aw/actions/runs/24061973971/job/70179864894

@lpcox lpcox marked this pull request as ready for review April 7, 2026 03:06
Copilot AI review requested due to automatic review settings April 7, 2026 03:06
@lpcox lpcox merged commit d229f86 into copilot/add-cli-proxy-feature-flag Apr 7, 2026
@lpcox lpcox deleted the copilot/fix-js-qmd-index-workflow branch April 7, 2026 03:06
Copilot stopped work on behalf of lpcox due to an error April 7, 2026 03:06
Copilot AI requested a review from lpcox April 7, 2026 03:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a stale CI job (js-qmd-index) that was still attempting to run a deleted test file (qmd_index.test.cjs), which was causing CI failures.

Changes:

  • Deleted the js-qmd-index job from the main CI workflow to stop running nonexistent tests.
Show a summary per file
File Description
.github/workflows/ci.yml Removes the obsolete js-qmd-index job that referenced deleted qmd index tests.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

lpcox added a commit that referenced this pull request Apr 7, 2026
…ll v0.25.14) (#24997)

* Initial plan

* feat: bump default AWF firewall version to v0.25.14

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2e432b55-8a31-4eb8-ab16-7602b03acea2

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* feat: add cli-proxy and cli-proxy-writable feature flags with AWF command injection

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2e432b55-8a31-4eb8-ab16-7602b03acea2

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* feat: add awfSupportsCliProxy version gate to prevent failures on older AWF versions

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/180bd43e-792e-4d72-b6b0-137eacfdd829

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: update wasm golden files for v0.25.14 and new actions permission (#25003)

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/45d7425a-e55e-4a76-8049-e58cad7ee0d6

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: resolve TypeScript errors in js workflow check (#25004)

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d97ec115-fca7-468f-8455-80e276a712cf

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* ci: remove stale js-qmd-index job whose test file was deleted (#25005)

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7417d3b0-97d5-4b8f-baf1-dff3635cd5d2

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: update assign_to_agent tests to use handler factory pattern (#25008)

* fix: restore backward compat in assign_to_agent.cjs for standalone tests

The main() function was refactored to a handler factory pattern but tests
still use the old standalone interface (env vars + direct item processing).
Add standalone mode detection when main() is called with no config:
- Reads config from env vars (GH_AW_AGENT_DEFAULT, GH_AW_AGENT_MAX_COUNT, etc.)
- Processes all assign_to_agent items from GH_AW_AGENT_OUTPUT
- Writes summary, sets outputs, calls setFailed on errors
Also fix the "Ignore-if-error mode enabled" log message to match tests.

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e00f51ce-33dd-493d-ba64-e13e1ebeb1be

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: address code review feedback on standalone mode detection

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e00f51ce-33dd-493d-ba64-e13e1ebeb1be

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* Update; rm -rf /

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* fix: update assign_to_agent tests to use handler factory pattern

Replace `await main()` standalone calls in test evals with a STANDALONE_RUNNER
snippet that simulates the safe-output handler manager flow:
- build config from env vars
- call main(config) to get the handler function
- process assign_to_agent items through the handler
- write summary, set outputs, call setFailed on errors

Also fix the "encounters auth errors" assertion to match the production log message.

No changes to assign_to_agent.cjs production code.

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d92459b5-9e9b-40ad-a0c6-108c70f23622

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants