fix: tighten "Upload Safe Outputs" step presence check in integration test#25485
Closed
fix: tighten "Upload Safe Outputs" step presence check in integration test#25485
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/05417776-28f4-49a8-bbbc-8f9fffc0d37b Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 9, 2026 13:40
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a flaky integration test assertion that incorrectly matched step names sharing the "Upload Safe Outputs" prefix.
Changes:
- Tightened the step presence check to match the exact YAML step line (
"- name: Upload Safe Outputs\n"). - Added clarifying comment explaining why exact matching is required (avoids false positives on sibling steps).
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/step_order_validation_integration_test.go | Updates the integration test to use an exact step-name match, preventing false positives from similarly named steps. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestStepOrderingValidation_SecretRedactionBeforeUploadswas failing because the substring check"name: Upload Safe Outputs"is a prefix match — it also hits the still-valid steps"Upload Safe Outputs Items"and"Upload Safe Outputs Assets".Change
Updated the check to use the exact step-name pattern
"- name: Upload Safe Outputs\n", consistent with the identical assertion inagentic_output_test.go: