Skip to content

fix: tighten "Upload Safe Outputs" step presence check in integration test#25485

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/fix-tests
Closed

fix: tighten "Upload Safe Outputs" step presence check in integration test#25485
Copilot wants to merge 1 commit intomainfrom
copilot/fix-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

TestStepOrderingValidation_SecretRedactionBeforeUploads was failing because the substring check "name: Upload Safe Outputs" is a prefix match — it also hits the still-valid steps "Upload Safe Outputs Items" and "Upload Safe Outputs Assets".

Change

Updated the check to use the exact step-name pattern "- name: Upload Safe Outputs\n", consistent with the identical assertion in agentic_output_test.go:

// Before — prefix match, unintentionally catches sibling steps
if strings.Contains(contentStr, "name: Upload Safe Outputs") { ... }

// After — exact step name, consistent with agentic_output_test.go
if strings.Contains(contentStr, "- name: Upload Safe Outputs\n") { ... }

@pelikhan pelikhan marked this pull request as ready for review April 9, 2026 13:40
Copilot AI review requested due to automatic review settings April 9, 2026 13:40
@pelikhan pelikhan closed this Apr 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a flaky integration test assertion that incorrectly matched step names sharing the "Upload Safe Outputs" prefix.

Changes:

  • Tightened the step presence check to match the exact YAML step line ("- name: Upload Safe Outputs\n").
  • Added clarifying comment explaining why exact matching is required (avoids false positives on sibling steps).
Show a summary per file
File Description
pkg/workflow/step_order_validation_integration_test.go Updates the integration test to use an exact step-name match, preventing false positives from similarly named steps.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions github-actions Bot deleted the copilot/fix-tests branch April 18, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants