Skip to content

fix: tighten "Upload Safe Outputs" step presence check in integration test #25485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 1 commit into from
Closed

fix: tighten "Upload Safe Outputs" step presence check in integration test #25485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/workflow/step_order_validation_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,9 @@ This workflow has a secret reference and safe-outputs.
}

// Upload Safe Outputs is now merged into the unified agent artifact; verify
// the old separate step no longer appears.
if strings.Contains(contentStr, "name: Upload Safe Outputs") {
// the old separate step no longer appears. Use exact matching (with leading "- " and
// trailing newline) to avoid false positives on steps like "Upload Safe Outputs Items".
if strings.Contains(contentStr, "- name: Upload Safe Outputs\n") {
t.Error("Upload Safe Outputs should be removed (merged into unified agent artifact)")
}

Expand Down
Loading