Skip to content

Docs: address multi-device accessibility/layout warnings (contrast, logo sizing, video loading) #27583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 21, 2026
+30 −1
Merged

Docs: address multi-device accessibility/layout warnings (contrast, logo sizing, video loading) #27583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a5bfe9
Initial plan
Copilot Apr 21, 2026
4958e43
fix(docs): improve contrast support and media loading hints
Copilot Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/components/CustomLogo.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const initialLogoUrl = darkLogoUrl;
---

<a href={homeUrl} class="site-title">
<img src={initialLogoUrl} alt="GitHub Agentic Workflows" class="theme-logo" data-dark-src={darkLogoUrl} data-light-src={lightLogoUrl} />
<img src={initialLogoUrl} alt="GitHub Agentic Workflows" class="theme-logo" width="24" height="24" data-dark-src={darkLogoUrl} data-light-src={lightLogoUrl} />
<span>GitHub Agentic Workflows</span>
</a>

Expand Down
2 changes: 2 additions & 0 deletions docs/src/components/Video.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ const accessibilityLabel = title || caption || fallbackLabel
const fallbackLinkLabel = accessibilityLabel
? `Download ${accessibilityLabel}`
: 'Download this video'
const loadingStrategy = autoStart ? 'eager' : 'lazy'
---

<div class="gh-aw-video-wrapper" style={`max-width: ${maxWidth};`}>
Expand All @@ -79,6 +80,7 @@ const fallbackLinkLabel = accessibilityLabel
muted={silenced}
poster={posterPath}
preload="metadata"
loading={loadingStrategy}
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loading is not a valid/recognized attribute for the HTML <video> element (it’s supported on <img>/<iframe>), so this won’t actually change video loading behavior and may still leave the audit warning unresolved. If the goal is to avoid network activity until needed, consider using a real video mechanism (e.g., preload="none" when autoStart is false, or deferring setting <source src> until the video is in/near the viewport via IntersectionObserver).

Copilot uses AI. Check for mistakes.
title={title}
aria-label={accessibilityLabel}
>
Expand Down
27 changes: 27 additions & 0 deletions docs/src/styles/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1779,3 +1779,30 @@ main,
transition: none;
}
}

@media (prefers-contrast: more) {
:focus-visible {
outline-width: 3px;
}

.site-title span,
.header-link {
text-decoration: underline;
}
}

@media (forced-colors: active) {
.site-title,
.header-link,
.gh-aw-video-container,
.gh-aw-video-caption {
border: 1px solid CanvasText;
background: Canvas;
color: CanvasText;
}

Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In forced-colors mode you set color: CanvasText on .site-title, but .site-title span has an explicit color rule elsewhere with higher specificity (and a separate light-theme override). That can override the forced-colors intent and produce low-contrast text. Consider explicitly setting .site-title span { color: CanvasText; } within this @media (forced-colors: active) block.

Suggested change
.site-title span {
color: CanvasText;
}

Copilot uses AI. Check for mistakes.
.header-link:hover,
.site-title:hover {
forced-color-adjust: auto;
}
Comment on lines +1803 to +1807
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forced-color-adjust: auto is the default behavior, so this hover rule is effectively a no-op. If you intended to override UA color adjustments, set the desired value (commonly none) on the base state; otherwise, removing this rule will reduce confusion.

Suggested change
.header-link:hover,
.site-title:hover {
forced-color-adjust: auto;
}

Copilot uses AI. Check for mistakes.
}
Loading