Remove duplicate log statements in parseUpdateEntityConfig#28634
Draft
Remove duplicate log statements in parseUpdateEntityConfig#28634
Conversation
3 tasks
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7a255b2c-67bb-47b6-a8c5-c2d135708257 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix duplicate log statements in parseUpdateEntityConfig
Remove duplicate log statements in parseUpdateEntityConfig
Apr 26, 2026
This comment has been minimized.
This comment has been minimized.
This was referenced Apr 26, 2026
Contributor
|
Hey One thing that would strengthen this PR before merge:
If you'd like a hand, here's a prompt you can assign to your coding agent:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseUpdateEntityConfiglogged identical messages to bothupdateEntityHelpersLog(file-level) and the caller-providedloggerat the same call sites, doubling debug output on everyupdate-issue,update-pull-request,update-discussion, etc. invocation.Changes
updateEntityHelpersLog.Printf("Parsing %s configuration", ...)— the caller'slogger.Printfalready emits this with a more specific prefix.logger.Printfthat preserves theConfigKeycontext previously only on the removed line.updateEntityHelpersLog.Printf("Parsed target config for %s: target=%s", ...)— it has no counterpart in the caller logger.