Skip to content

Remove duplicate log statements in parseUpdateEntityConfig #28634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −3
Draft

Remove duplicate log statements in parseUpdateEntityConfig #28634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64012ba
Initial plan
Copilot Apr 26, 2026
8672242
fix: remove duplicate log statements in parseUpdateEntityConfig
Copilot Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/workflow/update_entity_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,16 +125,14 @@ type UpdateEntityJobBuilder struct {
// parseUpdateEntityConfig is a generic function to parse update entity configurations
func (c *Compiler) parseUpdateEntityConfig(outputMap map[string]any, params UpdateEntityJobParams, logger *logger.Logger, parseSpecificFields func(map[string]any, *UpdateEntityConfig)) *UpdateEntityConfig {
if configData, exists := outputMap[params.ConfigKey]; exists {
updateEntityHelpersLog.Printf("Parsing %s configuration", params.ConfigKey)
logger.Printf("Parsing %s configuration", params.ConfigKey)
config := &UpdateEntityConfig{}

if configMap, ok := configData.(map[string]any); ok {
// Parse target config (target, target-repo) with validation
targetConfig, isInvalid := ParseTargetConfig(configMap)
if isInvalid {
updateEntityHelpersLog.Printf("Invalid target-repo configuration for %s", params.ConfigKey)
logger.Print("Invalid target-repo configuration")
logger.Printf("Invalid target-repo configuration for %s", params.ConfigKey)
return nil
}
config.SafeOutputTargetConfig = targetConfig
Expand Down