Fix lint-go failure from perfsprint violations in CLI and permissions validator#31231
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'lint-go'
Fix lint-go failure from perfsprint violations in CLI and permissions validator
May 9, 2026
Copilot stopped work on behalf of
pelikhan due to an error
May 9, 2026 16:10
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes lint-go failures caused by perfsprint violations by removing unnecessary string formatting calls while keeping behavior the same.
Changes:
- Replaced an unnecessary
fmt.Sprintfwith direct string concatenation in the interactive CLI engine selection flow. - Replaced static-message
fmt.Errorf(...)calls witherrors.New(...)in the permissions compiler validator (and added theerrorsimport).
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/permissions_compiler_validator.go | Uses errors.New for static error strings to satisfy perfsprint and keeps existing validator behavior. |
| pkg/cli/add_interactive_engine.go | Removes an unnecessary fmt.Sprintf when printing the selected/overridden engine message. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
165
to
+170
| if workflowPermissions == nil { | ||
| return fmt.Errorf("engine.auth.type: github-oidc requires permissions.id-token: write") | ||
| return errors.New("engine.auth.type: github-oidc requires permissions.id-token: write") | ||
| } | ||
|
|
||
| if level, exists := workflowPermissions.Get(PermissionIdToken); !exists || level != PermissionWrite { | ||
| return fmt.Errorf("engine.auth.type: github-oidc requires permissions.id-token: write") | ||
| return errors.New("engine.auth.type: github-oidc requires permissions.id-token: write") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
What was the bug?
The
lint-gojob failed in Actions job75165548320due toperfsprintviolations: one unnecessaryfmt.Sprintfand two static-stringfmt.Errorfcalls.How did you fix it?
pkg/cli/add_interactive_engine.go.fmt.Errorf(...)witherrors.New(...)inpkg/workflow/permissions_compiler_validator.go.errorsimport for the validator.Testing