Skip to content

Fix lint-go failure from perfsprint violations in CLI and permissions validator #31231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
May 9, 2026
+4 −3
Merged

Fix lint-go failure from perfsprint violations in CLI and permissions validator #31231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f94a796
Initial plan
Copilot May 9, 2026
42e9e04
fix: resolve lint-go perfsprint violations
Copilot May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cli/add_interactive_engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (c *AddInteractiveConfig) selectAIEngineAndKey() error {

// If engine is already overridden, skip selection
if c.EngineOverride != "" {
fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("Using coding agent: %s", c.EngineOverride)))
fmt.Fprintln(os.Stderr, console.FormatInfoMessage("Using coding agent: "+c.EngineOverride))
return c.configureEngineAPISecret(c.EngineOverride)
}

Expand Down
5 changes: 3 additions & 2 deletions pkg/workflow/permissions_compiler_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
package workflow

import (
"errors"
"fmt"
"os"
)
Expand Down Expand Up @@ -162,11 +163,11 @@ func validateEngineAuthPermissions(workflowData *WorkflowData, workflowPermissio
}

if workflowPermissions == nil {
return fmt.Errorf("engine.auth.type: github-oidc requires permissions.id-token: write")
return errors.New("engine.auth.type: github-oidc requires permissions.id-token: write")
}

if level, exists := workflowPermissions.Get(PermissionIdToken); !exists || level != PermissionWrite {
return fmt.Errorf("engine.auth.type: github-oidc requires permissions.id-token: write")
return errors.New("engine.auth.type: github-oidc requires permissions.id-token: write")
Comment on lines 165 to +170
}

return nil
Expand Down