Skip to content

Clarify direct safe-output usage in Daily Compiler Quality Check#40575

Merged
pelikhan merged 3 commits into
mainfrom
copilot/aw-fix-daily-compiler-workflow
Jun 21, 2026
Merged

Clarify direct safe-output usage in Daily Compiler Quality Check#40575
pelikhan merged 3 commits into
mainfrom
copilot/aw-fix-daily-compiler-workflow

Conversation

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

The Daily Compiler Quality Check could complete successfully without producing any recorded safe outputs. In the failing run, the agent invoked safeoutputs through bash, which bypassed the normal safe-output capture path and left the workflow with an empty result.

  • Root cause

    • The workflow prompt allowed an ambiguous execution path: the agent could create the discussion via shell instead of calling the safe-output tool directly.
    • When discussion creation did not produce a recorded safe output, the prompt did not make the noop fallback explicit enough for this failure mode.
  • Prompt contract changes

    • Require create_discussion and noop to be called directly as safe-output tools.
    • Explicitly forbid invoking safe outputs via bash, shell, or safeoutputs ... CLI commands.
    • Preserve the existing “single discussion” behavior when a valid report is available.
    • Add a required noop fallback when a valid discussion body cannot be produced.
  • Documentation in the workflow

    • Added direct tool-call examples for both create_discussion and noop to make the expected invocation pattern unambiguous.
  • Compiled workflow

    • Regenerated the lock file so the updated prompt contract is reflected in the executable workflow.

Example of the new expected pattern:

{"title":"Daily Compiler Code Quality Report - YYYY-MM-DD","category":"audits","body":"...full markdown report..."}

Fallback when no valid discussion should be created:

{"message":"No discussion created: [brief explanation]"}

Copilot AI and others added 2 commits June 21, 2026 04:55
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…workflow

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix daily compiler quality check to generate safe outputs Clarify direct safe-output usage in Daily Compiler Quality Check Jun 21, 2026
Copilot AI requested a review from pelikhan June 21, 2026 05:05
@pelikhan pelikhan marked this pull request as ready for review June 21, 2026 05:06
Copilot AI review requested due to automatic review settings June 21, 2026 05:06
@pelikhan pelikhan merged commit 7e28775 into main Jun 21, 2026
@pelikhan pelikhan deleted the copilot/aw-fix-daily-compiler-workflow branch June 21, 2026 05:06
Copilot stopped reviewing on behalf of pelikhan due to an error June 21, 2026 05:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the daily compiler quality workflow instructions to require direct safe-output tool calls, and regenerates gh-aw lock metadata to reflect the updated prompt content.

Changes:

  • Clarify the output contract to require direct create_discussion / noop tool calls (and forbid invoking safe outputs via shell/CLI).
  • Add examples for direct tool calls in the daily compiler quality workflow markdown.
  • Regenerate .lock.yml workflow lockfiles (updated body_hash metadata).
Show a summary per file
File Description
.github/workflows/smoke-copilot.lock.yml Regenerated gh-aw lock metadata (body_hash) after prompt/content changes.
.github/workflows/daily-compiler-quality.md Tightens output contract to require direct tool calls and adds illustrative examples.
.github/workflows/daily-compiler-quality.lock.yml Regenerated gh-aw lock metadata (body_hash) after prompt/content changes.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 1

Comment on lines +376 to +378
### Direct Tool Call Examples

Use the `create_discussion` tool directly:
@github-actions github-actions Bot mentioned this pull request Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants