Clarify direct safe-output usage in Daily Compiler Quality Check#40575
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…workflow Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix daily compiler quality check to generate safe outputs
Clarify direct safe-output usage in Daily Compiler Quality Check
Jun 21, 2026
pelikhan
approved these changes
Jun 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the daily compiler quality workflow instructions to require direct safe-output tool calls, and regenerates gh-aw lock metadata to reflect the updated prompt content.
Changes:
- Clarify the output contract to require direct
create_discussion/nooptool calls (and forbid invoking safe outputs via shell/CLI). - Add examples for direct tool calls in the daily compiler quality workflow markdown.
- Regenerate
.lock.ymlworkflow lockfiles (updatedbody_hashmetadata).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-copilot.lock.yml | Regenerated gh-aw lock metadata (body_hash) after prompt/content changes. |
| .github/workflows/daily-compiler-quality.md | Tightens output contract to require direct tool calls and adds illustrative examples. |
| .github/workflows/daily-compiler-quality.lock.yml | Regenerated gh-aw lock metadata (body_hash) after prompt/content changes. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
Comment on lines
+376
to
+378
| ### Direct Tool Call Examples | ||
|
|
||
| Use the `create_discussion` tool directly: |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Daily Compiler Quality Check could complete successfully without producing any recorded safe outputs. In the failing run, the agent invoked
safeoutputsthroughbash, which bypassed the normal safe-output capture path and left the workflow with an empty result.Root cause
noopfallback explicit enough for this failure mode.Prompt contract changes
create_discussionandnoopto be called directly as safe-output tools.bash,shell, orsafeoutputs ...CLI commands.noopfallback when a valid discussion body cannot be produced.Documentation in the workflow
create_discussionandnoopto make the expected invocation pattern unambiguous.Compiled workflow
Example of the new expected pattern:
{"title":"Daily Compiler Code Quality Report - YYYY-MM-DD","category":"audits","body":"...full markdown report..."}Fallback when no valid discussion should be created:
{"message":"No discussion created: [brief explanation]"}