refactor: move agentic-workflow-designer skill to static instruction file#44658
Conversation
… agentic-workflows - Create .github/skills/agentic-workflows/designer.md as a loadable instruction file (without skill frontmatter) - Update agentic-workflows dispatcher to reference the new designer path (.github/skills/agentic-workflows/designer.md) instead of the old standalone skill (.github/skills/agentic-workflow-designer/SKILL.md) - Remove ensureAgenticWorkflowDesignerSkill from copilot_agents.go and the embedded agentic_workflow_designer_skill.md data file - Add deleteAgenticWorkflowDesignerSkillDir to clean up legacy installations when users run gh aw init - Remove designer skill generation from init.go; add cleanup call - Update init_command.go long description - Update designer-drift-audit.md to reference new path and recompile - Update tests accordingly Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot move designer.md to .github/aw/designer.md |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done. Moved |
|
@copilot merge main and recompile |
There was a problem hiding this comment.
Pull request overview
This PR refactors the “workflow designer” content from a separately-installed Copilot skill into a plain markdown instruction file that the agentic-workflows dispatcher can load on demand, reducing init-time templating/sync complexity and removing legacy artifacts.
Changes:
- Stop writing the legacy
agentic-workflow-designerskill duringgh aw init, and add cleanup to remove existing legacy installs. - Update dispatcher skill content (template + checked-in SKILL.md) to route “design” requests to the new designer instruction file.
- Update drift-audit workflow to track the new designer file path, and update tests accordingly.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/init.go | Removes designer-skill creation during init; adds legacy directory cleanup call. |
| pkg/cli/init_command.go | Updates init help text to no longer claim the designer skill is created. |
| pkg/cli/init_command_test.go | Updates init help-text and filesystem assertions to match the new artifact set. |
| pkg/cli/data/agentic_workflows_skill.md | Updates dispatcher template routing to point at the new designer instruction file path. |
| pkg/cli/data/agentic_workflows_fallback_aw_files.json | Adds designer.md to the embedded fallback allowlist for upstream aw files. |
| pkg/cli/data/agentic_workflow_designer_skill.md | Deletes the embedded designer skill template (no longer written to user repos). |
| pkg/cli/copilot_agents.go | Removes designer-skill embed + write logic; adds legacy directory removal helper. |
| pkg/cli/copilot_agents_test.go | Updates assertions to expect routing to .github/aw/designer.md and drops template-sync test. |
| .github/workflows/designer-drift-audit.md | Updates drift audit to inspect .github/aw/designer.md instead of the removed skill file. |
| .github/workflows/designer-drift-audit.lock.yml | Recompiled lock output reflecting the drift audit path change. |
| .github/skills/agentic-workflows/SKILL.md | Updates dispatcher file list and routing to include .github/aw/designer.md. |
| .github/aw/designer.md | Removes skill frontmatter and adjusts content for the new “instruction file” usage. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/aw/designer.md:9
- This file now lives at
.github/aw/designer.md, but the instructions still reference.github/skills/agentic-workflows/designer.md(which doesn’t exist in the repo). This creates a broken/self-contradictory reference for users following the designer flow.
- Files reviewed: 12/12 changed files
- Comments generated: 2
- Review effort level: Low
| SKILL=".github/aw/designer.md" | ||
| if [ -f "$SKILL" ]; then | ||
| { | ||
| echo "=== SKILL.md ===" |
| After loading the matching workflow prompt or skill, follow it directly: | ||
| - Design workflows from scratch via interview: `skills/agentic-workflow-designer/SKILL.md` | ||
| - Design workflows from scratch via interview: `.github/aw/designer.md` | ||
| - Create new workflows: `.github/aw/create-agentic-workflow.md` |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…tic-workflows-design # Conflicts: # .github/workflows/designer-drift-audit.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
🎉 This pull request is included in a new release. Release: |
The
agentic-workflow-designerwas a separate skill written to every user repo bygh aw init, requiring an embedded Go template and sync logic to keep it up-to-date. Theagentic-workflowsdispatcher SKILL.md was larger than necessary, embedding designer routing alongside the file list.Changes
New instruction file
.github/skills/agentic-workflows/designer.md— designer interview framework as a plain markdown instruction file (no skill frontmatter), served fromgithub/gh-awand loaded by the dispatcher on demandDispatcher minimized
pkg/cli/data/agentic_workflows_skill.md+ checked-inSKILL.md— reference changed fromskills/agentic-workflow-designer/SKILL.md→.github/skills/agentic-workflows/designer.mdinit no longer writes the designer skill
pkg/cli/copilot_agents.go— removedensureAgenticWorkflowDesignerSkill, removed//go:embed data/agentic_workflow_designer_skill.md; addeddeleteAgenticWorkflowDesignerSkillDirto clean up legacy installations on nextinitpkg/cli/init.go— removed designer write call; added cleanup callpkg/cli/data/agentic_workflow_designer_skill.md— deletedDeleted
.github/skills/agentic-workflow-designer/SKILL.mdand directory — replaced bydesigner.mdDrift audit updated
.github/workflows/designer-drift-audit.md— path updated to.github/skills/agentic-workflows/designer.md; recompiled