Use live gh-aw version for MCP inspector and make tool icons spec-compliant

[Copilot]

The MCP SDK review surfaced two small protocol-alignment gaps in gh-aw: the inspector client reported a hardcoded version, and MCP tool icons used raw emoji instead of URI-backed icon sources. This change aligns the MCP metadata we emit with the SDK/spec while preserving current UX.

• Inspector client identity

  • Replace the hardcoded gh-aw-inspector version with GetVersion().
  • This keeps remote MCP server logs and diagnostics aligned with the actual CLI version in use.

• Spec-compliant MCP tool icons

  • Replace raw emoji Icon.Source values with generated data:image/svg+xml,... URIs.
  • Preserve the same visible glyphs (📊, 📋, 🔍, etc.) while making the icon payload valid for stricter MCP clients.
  • Centralize icon generation in a small helper so all tool registrations stay consistent.

• Focused test coverage

  • Add a unit test for inspector client version wiring.
  • Add a unit test for SVG data-URI icon generation.
  • Update MCP server icon expectations to assert the new URI form.

Example of the new icon encoding approach:

func mcpToolIcons(emoji string) []mcp.Icon {
	return []mcp.Icon{{Source: mcpEmojiIconSource(emoji)}}
}

func mcpEmojiIconSource(emoji string) string {
	svg := fmt.Sprintf(
		`<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><text x="16" y="24" font-size="24" text-anchor="middle">%s</text></svg>`,
		emoji,
	)
	return "data:image/svg+xml," + url.PathEscape(svg)
}

[Copilot]

Pull request overview

Aligns MCP client metadata and tool icons with protocol expectations.

Changes:

• Uses the live CLI version for MCP inspector clients.
• Centralizes MCP tool icon generation and updates tests.
• Changes the generated auto-upgrade schedule.

Show a summary per file

File	Description
pkg/cli/mcp_tools_readonly.go	Uses shared icon generation.
pkg/cli/mcp_tools_privileged.go	Uses shared icon generation.
pkg/cli/mcp_tools_management.go	Uses shared icon generation.
pkg/cli/mcp_tool_icons.go	Generates SVG data-URI icons.
pkg/cli/mcp_server_tools_test.go	Updates icon expectations.
pkg/cli/mcp_inspect_test.go	Tests version and icon generation.
pkg/cli/mcp_inspect_mcp.go	Reports the live CLI version.
.github/workflows/agentic-auto-upgrade.yml	Changes the weekly execution time.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 8/8 changed files
• Comments generated: 2
• Review effort level: Medium

[Copilot]

Reverted in the latest commit. The cron is back to "21 3 * * 5" (Friday) as it was on the base branch.

[gh-aw-bot]

@copilot please run the pr-finisher skill and address these unresolved review threads:

• copilot-pull-request-reviewer: Use live gh-aw version for MCP inspector and make tool icons spec-compliant #45450 (comment)
• copilot-pull-request-reviewer: Use live gh-aw version for MCP inspector and make tool icons spec-compliant #45450 (comment)
  Then rerun checks and update the PR with the results.

Generated by 👨‍🍳 PR Sous Chef · 14.8 AIC · ⌖ 7.41 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}