Skip to content

Simplify workshop guided run by removing the progress box#46598

Merged
pelikhan merged 2 commits into
mainfrom
copilot/simplify-workshopexperience
Jul 19, 2026
Merged

Simplify workshop guided run by removing the progress box#46598
pelikhan merged 2 commits into
mainfrom
copilot/simplify-workshopexperience

Conversation

Copilot AI commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

The guided run UI included a large progress box that added visual weight without improving navigation. This change simplifies the workshop experience by removing that box and collapsing the related implementation.

  • What changed

    • Removed the guided run progress card from the workshop panel layout.
    • Kept the step position indicator in the header as the single progress affordance.
    • Preserved existing navigation controls (Home, Change route, previous/next step).
  • Component cleanup

    • Deleted the progress-card markup from WorkshopExperience.astro.
    • Removed the client-side progress calculation and DOM updates that only existed to drive the removed UI.
    • Dropped the unused progress-card styles and responsive rules.
  • Test updates

    • Updated workshop Playwright coverage to assert step-position behavior and the simplified layout.
    • Removed expectations tied to the deleted progress card.
<div class="aw-workshop-panel-heading">
  <p class="aw-workshop-panel-meta" data-workshop-step-position>Step 1</p>
  <p class="aw-workshop-panel-summary" data-workshop-step-summary>...</p>
</div>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Simplify the workshop guided run layout Simplify workshop guided run by removing the progress box Jul 19, 2026
Copilot AI requested a review from pelikhan July 19, 2026 11:52
@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage

Field Value
Category chore
Risk Low
Priority Score 28/100
Score Breakdown Impact: 12 · Urgency: 8 · Quality: 8
Action defer

Rationale: Small draft UI cleanup (+1/−119). Draft status — not ready for merge. Low user impact; safe to defer until author marks ready.

Generated by 🔧 PR Triage Agent · 41.2 AIC · ⌖ 7.94 AIC · ⊞ 5.6K ·

@github-actions

Copy link
Copy Markdown
Contributor

Workshop simplification looks solid!

This PR follows the core team's agentic development process. The change is well-focused on removing the progress box visual weight while preserving the step indicator affordance.

What stands out:

  • Clear, focused change
  • Comprehensive PR body with before/after rationale
  • Test updates included (Playwright coverage)
  • Mostly deletion — good cleanup

Ready for review. 🎉

Generated by ✅ Contribution Check · 56.3 AIC · ⌖ 9.77 AIC · ⊞ 6.2K ·

@pelikhan
pelikhan marked this pull request as ready for review July 19, 2026 14:00
Copilot AI review requested due to automatic review settings July 19, 2026 14:00
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the redundant workshop progress card while retaining step-position navigation.

Changes:

  • Removed progress-card markup, scripting, and styles.
  • Updated Playwright tests for the simplified layout and step indicator.
Show a summary per file
File Description
docs/tests/workshop.spec.ts Removes progress-card assertions.
docs/src/components/workshop/WorkshopExperience.astro Removes progress UI and supporting implementation.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Medium

…shopexperience

# Conflicts:
#	docs/src/components/workshop/WorkshopExperience.astro

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts on this branch.

Merge conflicts resolved in 92832a2. The two conflicts were in the CSS section of WorkshopExperience.astro — I kept our removal of the progress card styles over main's expanded version, and accepted main's removal of .aw-workshop-step-content from the light-theme box-shadow rule. Also cleaned up orphaned progressCard/progressCardStyle references in the test file that crept in via the auto-merge and would have caused test failures.

@pelikhan
pelikhan merged commit 084afe5 into main Jul 19, 2026
@pelikhan
pelikhan deleted the copilot/simplify-workshopexperience branch July 19, 2026 14:53
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, confirm the branch is current, and summarize the next concrete maintainer action after checks are current.

Run: https://github.com/github/gh-aw/actions/runs/29691425979

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • pi.dev

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "pi.dev"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · 9.52 AIC · ⌖ 6.01 AIC · ⊞ 7.5K ·
Comment /souschef to run again

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants