fix: remove unused assert import causing fuzz build failure#47286
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
This PR propagates an “evals AIC” signal through many GitHub Actions workflows by adding a log-parsing step that surfaces an aic output, and wires that output into downstream jobs via a new GH_AW_EVALS_AIC environment variable.
Changes:
- Adds
GH_AW_EVALS_AIC: ${{ needs.evals.outputs.aic }}to many workflow job env blocks. - Adds a
parse-mcp-gatewayactions/github-scriptstep and exports a job-leveloutputs.aicfrom that step’s output. - Removes the
testify/assertimport from a Go test file.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/forbidden_fields_import_test.go | Removes an import to align with current test usage. |
| .github/workflows/weekly-blog-post-writer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/unbloat-docs.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/tidy.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/technical-doc-writer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/sub-issue-closer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/stale-repo-identifier.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/stale-pr-cleanup.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/spec-enforcer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/smoke-copilot.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/security-review.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/refiner.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/pr-code-quality-reviewer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/plan.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/necromancer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/issue-triage-agent.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/issue-monster.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/issue-arborist.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/hourly-ci-cleaner.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/glossary-maintainer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/duplicate-code-detector.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/draft-pr-cleanup.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/dependabot-go-checker.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/deepsec-security-scan.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-yamllint-fixer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-vulnhunter-scan.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-syntax-error-quality.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-sentrux-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-semgrep-scan.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-security-red-team.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-security-observability.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-secrets-analysis.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-safe-outputs-conformance.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-safe-output-integrator.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-repo-chronicle.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-reliability-review.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-regulatory.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-performance-summary.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-observability-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-news.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-model-inventory.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-malicious-code-scan.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-issues-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-hippo-learn.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-geo-optimizer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-function-namer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-firewall-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-file-diet.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-fact.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-experiment-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-evals-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-elixir-credo-snippet-audit.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-doc-updater.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-doc-healer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-compiler-threat-spec-optimizer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-compiler-quality.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-community-attribution.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-code-metrics.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-cli-tools-tester.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-cli-performance.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-caveman-optimizer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-cache-strategy-analyzer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-aw-cross-repo-compile-check.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-astrostylelite-markdown-spellcheck.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-architecture-diagram.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-ambient-context-optimizer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/daily-agent-of-the-day-blog-writer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/craft.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-session-insights.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-opt.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-centralization-optimizer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-centralization-drilldown.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/copilot-agent-analysis.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/contribution-check.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/commit-changes-analyzer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/code-simplifier.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/code-scanning-fixer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/cli-version-checker.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/cli-consistency-checker.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/claude-code-user-docs-review.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/ci-doctor.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/ci-coach.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/changeset.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/breaking-change-checker.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/brave.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/bot-detection.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/blog-auditor.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/aw-failure-investigator.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/avenger.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/auto-triage-issues.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/audit-workflows.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/artifacts-summary.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/architecture-guardian.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/archie.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/approach-validator.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/api-consumption-report.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/agentic-token-trend-audit.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/agentic-token-optimizer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/agentic-token-audit.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/agent-persona-explorer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/agent-performance-analyzer.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/ace-editor.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
| .github/workflows/ab-testing-advisor.lock.yml | Exposes evals aic output and threads it via GH_AW_EVALS_AIC; adds MCP gateway log parsing step. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (2)
.github/workflows/weekly-blog-post-writer.lock.yml:1
- This step runs on
always()but is not markedcontinue-on-error. If the MCP gateway log file (or the required script) is missing/corrupt, the workflow will fail even when all prior steps succeeded. If this is intended to be best-effort summary/telemetry, setcontinue-on-error: trueand/or make the script tolerate missing inputs (e.g., detect file existence before parsing) so it doesn’t turn incidental logging issues into job failures.
.github/workflows/weekly-blog-post-writer.lock.yml:1 - The job-level
outputs.aicis sourced fromsteps.parse-mcp-gateway.outputs.aic, butactions/github-scriptonly exposes outputs that the script explicitly sets (viacore.setOutput). Ensureparse_mcp_gateway_log.cjs(or this wrapper script) callscore.setOutput('aic', value); otherwise this output will always be empty and downstreamneeds.evals.outputs.aicwill not carry the intended value.
- Files reviewed: 108/108 changed files
- Comments generated: 0
- Review effort level: Low
|
🎉 This pull request is included in a new release. Release: |
The
fuzz (Workflow-Core)CI job was failing with a build error due to an unused import in a test file taggedintegration.Change
pkg/workflow/forbidden_fields_import_test.go: Remove unused"github.com/stretchr/testify/assert"import — onlyrequireis used in this file.The fuzz runner builds with
-tags=integration, which surfaces this file and triggers the compile error, while regular unit test runs skip it.