Add regression coverage for PR review path-resolution fallback#47380
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Broaden PR-review 422 fallback to match 'Path could not be resolved'
Add regression coverage for PR review path-resolution fallback
Jul 22, 2026
pelikhan
marked this pull request as ready for review
July 22, 2026 18:59
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage for indexed path-resolution failures during PR review submission.
Changes:
- Verifies resolvable comments remain inline.
- Verifies unresolvable path comments move to the review body.
- Confirms the retry warning remains informative.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/pr_review_buffer.test.cjs |
Adds focused partial-anchor fallback coverage for path-resolution errors. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub can reject inline PR review comments with 422
"Path could not be resolved"in the same fallback family as"Line could not be resolved". This path-based variant was not covered by tests, leaving the safe-output body/partial-anchor fallback effectively unvalidated.What changed
actions/setup/js/pr_review_buffer.test.cjsfor a review submission that fails with:message: "Path could not be resolved"field: "comments[1].path"Why this matters
Example scenario covered