fix: add integration build verification to catch fuzz build failures on PRs by Copilot · Pull Request #47398 · github/gh-aw

Copilot · 2026-07-22T20:42:46Z

Fuzz run #18583 on main failed because FuzzSanitizeOutput (which builds with -tags=integration) couldn't compile due to an unused assert import in forbidden_fields_import_test.go. The root-cause import removal landed in 94beb4a677; this PR adds a guard so the same class of failure is caught before reaching main.

Changes

test job — adds go test -run='^$' -tags=integration ./... after dependency verification. Compiles all integration-tagged test files on every push/PR without running any tests, exposing build errors (unused imports, missing symbols) that the regular -tags '!integration' step silently skips.
fuzz job — adds the same step as a pre-flight check before the fuzz matrix runs. Ensures integration-tagged files compile cleanly so a build failure surfaces with a clear error rather than a misleading fuzz-test failure.

The underlying issue: regular CI excludes integration files; the fuzz job was the only thing that compiled them, and it ran only on main.

Fixes [CGO][FUZZ] Workflow failure on main - Run #18583 #47277

Run: https://github.com/github/gh-aw/actions/runs/29961275366

Generated by 👨‍🍳 PR Sous Chef · gpt54 14.3 AIC · ⌖ 7.21 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}

…ilures Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Adds CI verification for integration-tagged Go tests to catch compilation failures before fuzzing on main.

Changes:

Adds integration build checks to the test and fuzz jobs.
Compiles integration-tagged packages without selecting tests.

Show a summary per file

File	Description
`.github/workflows/cgo.yml`	Adds integration build verification steps.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

.github/workflows/cgo.yml:1391

-run='^$' does not suppress TestMain; the integration-tagged CLI package runs make build before m.Run() (pkg/cli/compile_integration_test.go:33-87). Because this job has four matrix entries, that unintended setup is repeated four times. Use a no-op test executor to keep this pre-flight step compile-only.

        go test -run='^$' -tags=integration ./...

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Medium

+        # Regular unit tests use -tags '!integration', so build errors in
+        # integration-tagged files (e.g. unused imports) would otherwise
+        # go undetected until the fuzz job runs on main.
+        go test -run='^$' -tags=integration ./...


github-actions · 2026-07-22T22:04:17Z

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

github-actions · 2026-07-22T22:04:19Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (0 additions detected).

github-actions · 2026-07-22T22:04:24Z

✅ PR Code Quality Reviewer completed the code quality review.

github-actions · 2026-07-22T22:04:51Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

gh-aw-bot · 2026-07-22T22:07:56Z

@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

Open unresolved review feedback (newest first):

copilot-pull-request-reviewer: fix: add integration build verification to catch fuzz build failures on PRs #47398 (comment)

Generated by 👨‍🍳 PR Sous Chef · gpt54 14.3 AIC · ⌖ 7.21 AIC · ⊞ 7K · ◷
_{Comment /souschef to run again}

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs — requesting changes on one issue that affects both new steps.

📋 Key Findings

Issue: `go test -run='^$'` triggers `TestMain` side-effects

Both new "Verify integration build" steps use go test -run='^$' -tags=integration ./.... While -run='^$' prevents test functions from running, it does not prevent TestMain from executing. pkg/cli/compile_integration_test.go has a TestMain that calls make build, so this step will unexpectedly build the binary on every CI run.

The fix is to use go build -tags=integration ./... instead, which is the correct tool for build verification without test execution side-effects.

Positive Highlights

✅ The root cause is well-understood and the PR description is clear
✅ Adding the guard in both the test and fuzz jobs is the right scope

@copilot please address the review comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 16.7 AIC · ⌖ 4.63 AIC · ⊞ 6.7K
_{Comment /matt to run again}

github-actions

REQUEST_CHANGES — the integration build verification step uses the wrong tool and lacks a timeout.

### Key issues

go test -run='^$' is not a compile-only check — it executes TestMain in every package. In this repo, pkg/cli's TestMain runs make build, so both the test and fuzz job steps silently do a full binary build. The comments say "compile cleanly" but the command does substantially more. Use go test -c -tags=integration -o /dev/null ./... for a true compile-only check where TestMain is never invoked.

No step-level timeout — since TestMain runs make build, a hung network fetch or build step can block the runner indefinitely. Add timeout-minutes: 5 to both new steps.

The existing review comment (line 121) covers the test job variant; the fuzz job variant at line ~1391 has the same problem and needs the same fix.

🔎 Code quality review by PR Code Quality Reviewer · sonnet46 29.7 AIC · ⌖ 4.72 AIC · ⊞ 5.7K
_{Comment /review to run again}

github-actions · 2026-07-22T22:09:59Z

+        # Fuzz tests such as FuzzSanitizeOutput run with -tags=integration; a build
+        # error in any integration-tagged file causes the entire fuzz run to fail
+        # with a misleading error message.
+        go test -run='^$' -tags=integration ./...


TestMain still executes — not a pure compile check: the fuzz job step runs test binaries in every package (including pkg/cli which invokes make build), silently doing more work than the comment claims and potentially masking real intent.

💡 Suggested fix

Use -c to compile without executing:

go test -c -tags=integration -o /dev/null ./...

go test -c compiles each test binary and discards it; TestMain is never invoked. This gives a true compile-only check. The same fix applies to the test job equivalent step.

github-actions

Integration build verification — `TestMain` side-effect

The goal of catching unused-import build errors is correct and valuable. However, both new steps use go test -run='^$' -tags=integration ./... which, despite the empty run filter, still executes TestMain in pkg/cli/compile_integration_test.go. That TestMain calls make build to produce a binary (unless GH_AW_INTEGRATION_BINARY is set), turning a cheap compile check into a full binary build.

Recommended fix: Replace with go vet -tags=integration ./..., which type-checks all packages including integration-tagged test files without invoking TestMain:

- name: Verify integration build
  run: go vet -tags=integration ./...

See inline comments for both affected locations.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 21.4 AIC · ⌖ 4.61 AIC · ⊞ 5K

github-actions · 2026-07-22T22:10:32Z

+        # Fuzz tests such as FuzzSanitizeOutput run with -tags=integration; a build
+        # error in any integration-tagged file causes the entire fuzz run to fail
+        # with a misleading error message.
+        go test -run='^$' -tags=integration ./...


Same TestMain-executes-make build issue as line 121: go test -run='^$' -tags=integration ./... still invokes TestMain in pkg/cli/compile_integration_test.go, which calls make build unless GH_AW_INTEGRATION_BINARY is set.

Prefer go vet -tags=integration ./... which type-checks all packages (including integration-tagged test files) without executing TestMain or building the binary:

- name: Verify integration build run: go vet -tags=integration ./...

Alternatively, keep go test but supply a dummy binary path so TestMain skips the build:

- name: Verify integration build env: GH_AW_INTEGRATION_BINARY: /bin/true run: go test -run='^$' -tags=integration ./...

@copilot please address this.

pelikhan · 2026-07-22T22:11:10Z

@copilot Run pr-finisher skill

Done

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-22T22:21:45Z

@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

Open unresolved review feedback (newest first):...

Addressed in 7f1e235. The integration verification steps now use go test -run='^$' -exec=true -tags=integration ./... in both test and fuzz jobs, so test binaries are built/linked without executing TestMain side effects.

github-actions · 2026-07-23T12:17:06Z

🎉 This pull request is included in a new release.

Release: v0.83.1

Initial plan

5fd581e

Copilot AI assigned Copilot and pelikhan Jul 22, 2026

Copilot started work on behalf of pelikhan July 22, 2026 20:45 View session

Copilot AI linked an issue Jul 22, 2026 that may be closed by this pull request

[CGO][FUZZ] Workflow failure on main - Run #18583 #47277

Closed

fix: add integration build verification step to prevent fuzz build fa…

1ba6730

…ilures Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix workflow failure in fuzz job on main~~ fix: add integration build verification to catch fuzz build failures on PRs Jul 22, 2026

Copilot finished work on behalf of pelikhan July 22, 2026 21:03

Copilot AI requested a review from pelikhan July 22, 2026 21:03

pelikhan marked this pull request as ready for review July 22, 2026 21:57

Copilot AI review requested due to automatic review settings July 22, 2026 21:57

Copilot started reviewing on behalf of pelikhan July 22, 2026 21:57 View session

Copilot AI reviewed Jul 22, 2026

View reviewed changes

Comment thread .github/workflows/cgo.yml Outdated

# Regular unit tests use -tags '!integration', so build errors in

# integration-tagged files (e.g. unused imports) would otherwise

# go undetected until the fuzz job runs on main.

go test -run='^$' -tags=integration ./...

Merge branch 'main' into copilot/cgo-fix-workflow-failure-again

691f01a

github-actions Bot mentioned this pull request Jul 22, 2026

[pr-sous-chef] PR Sous Chef run report #47158

Closed

Copilot started work on behalf of gh-aw-bot July 22, 2026 22:08 View session

github-actions Bot requested changes Jul 22, 2026

View reviewed changes

Comment thread .github/workflows/cgo.yml

github-actions Bot requested changes Jul 22, 2026

View reviewed changes

github-actions Bot previously requested changes Jul 22, 2026

View reviewed changes

fix(ci): avoid TestMain side effects in integration build checks

7f1e235

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 22, 2026 22:28

Copilot AI requested a review from gh-aw-bot July 22, 2026 22:28

Copilot started work on behalf of pelikhan July 22, 2026 22:28 View session

Copilot stopped work on behalf of pelikhan due to an error July 22, 2026 22:32
Execution failed: Error: Model "claude-sonnet-4.5" is not available.

pelikhan approved these changes Jul 22, 2026

View reviewed changes

pelikhan merged commit 1a1b36c into main Jul 22, 2026
1 check failed

pelikhan deleted the copilot/cgo-fix-workflow-failure-again branch July 22, 2026 22:37

github-actions Bot mentioned this pull request Jul 23, 2026

Smoke Test: MAI-Code-1-Flash - 29984252050 #47489

Closed

Uh oh!

Conversation

Copilot AI commented Jul 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gh-aw-bot commented Jul 22, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Issue: go test -run='^$' triggers TestMain side-effects

Positive Highlights

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Integration build verification — TestMain side-effect

Uh oh!

github-actions Bot Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Jul 22, 2026

Uh oh!

Copilot AI commented Jul 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 22, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Issue: `go test -run='^$'` triggers `TestMain` side-effects

Integration build verification — `TestMain` side-effect