Fix container scan exit handling and failure propagation#47420
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
reviewed
Jul 22, 2026
| @@ -61,7 +61,13 @@ steps: | |||
| post-steps: | |||
Contributor
Author
There was a problem hiding this comment.
Moved the enforcement gate into the normal pre-agent steps list and recompiled the workflow in 7d93461.
Copilot
AI
changed the title
[WIP] Add logging and fix job failure handling
Fix container scan exit handling and failure propagation
Jul 22, 2026
pelikhan
marked this pull request as ready for review
July 22, 2026 23:24
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes scanner exit handling, improves diagnostics, and propagates scan failures to the agent job.
Changes:
- Handles Grype findings exit code
2and Grant nonzero exits safely. - Logs scanner errors and platform summaries.
- Fails the agent gate when scanning fails.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/daily-squid-image-scan.md |
Updates scan and failure-handling logic. |
.github/workflows/daily-squid-image-scan.lock.yml |
Regenerates the compiled workflow. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
This was referenced Jul 23, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container scan aborted when Grype reported critical findings with exit code
2, preventing result generation and obscuring diagnostics. Scan job failures also need to fail the dependent agent job.Scanner execution
bash -e.2as findings, not an operational error.Diagnostics
Failure propagation
scan_imagedoes not succeed.