Limit container image scanning to gh-* workflow images#47429
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Hey Here's what would help get this across the finish line:
The PR is already marked as draft with deferred action, which is fine. Once test coverage is added, this should be ready for merge. If you'd like a hand, you can assign this prompt to your coding agent:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the daily squid image scan workflow to filter the set of container images collected from workflow lock manifests before generating images.json.
Changes:
- Adds a
jqfilter to include only containers whose.imagematches(^|/)gh-[^/:@]+. - Regenerates the workflow lock file metadata and applies the same
jqchange to the locked workflow.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/daily-squid-image-scan.md | Narrows the images list via a jq select() filter before de-dup/sort. |
| .github/workflows/daily-squid-image-scan.lock.yml | Regenerates lock metadata and mirrors the image filtering logic in the locked workflow copy. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Low
| [ | ||
| .[].containers[]? | ||
| | select(.image | test("(^|/)gh-[^/:@]+")) | ||
| ] |
| [.[].containers[]?] | ||
| [ | ||
| .[].containers[]? | ||
| | select(.image | test("(^|/)gh-[^/:@]+")) |
|
🎉 This pull request is included in a new release. Release: |
The daily container image scan was sweeping every container referenced by compiled workflow manifests, including third-party MCP and example images. This change narrows the scan set to GitHub-owned
gh-*images so the workflow reports on the containers we maintain.Scope reduction
gh-*are included inimages.json.gh-awand related GitHub-managed containers such asgh-aw-firewall/*,gh-aw-node, andgh-aw-mcpg.Workflow behavior
Generated artifacts
daily-squid-image-scan.lock.ymlto keep the generated workflow in sync with the source workflow.