Skip to content

Surface aw.yml config during add-wizard before generic engine setup#47462

Merged
pelikhan merged 8 commits into
mainfrom
copilot/fix-manifest-config-recognition
Jul 23, 2026
Merged

Surface aw.yml config during add-wizard before generic engine setup#47462
pelikhan merged 8 commits into
mainfrom
copilot/fix-manifest-config-recognition

Conversation

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

gh aw add already detected packages that declare aw.yml config and redirected users to add-wizard, but add-wizard still entered the default engine-selection flow instead of honoring manifest-defined interactive setup. This change makes the wizard recognize manifest config early enough to run the intended package-specific prompts.

  • Wizard flow

    • Resolve the package bootstrap profile up front in add-wizard.
    • Run manifest-driven, engine-independent setup steps before the generic engine prompt.
    • Preserve the existing later-stage execution for actions that depend on install/auth context.
  • Config phase split

    • Pre-install / early wizard: require-owner-type, repo-variable, repo-secret, github-app
    • Post-install / late wizard: copilot-auth, commit-and-push, handoff
    • Keep the remaining-action path explicit so non-write-access flows only show the steps that still remain.
  • Bootstrap profile filtering

    • Add focused helpers to derive pre-install and post-install views of a manifest config.
    • Return nil when no actions survive filtering, so callers naturally skip empty phases.
    • Ignore unsupported action types rather than leaking them into either phase.
  • Regression coverage

    • Add tests that verify:
      • the exact action split between early and late wizard phases
      • original profile data remains unchanged
      • unsupported actions are excluded from both phases
preInstall := bootstrapProfileAddWizardPreInstall(profile)
postInstall := bootstrapProfileAddWizardPostInstall(profile)

// early wizard prompts
// - require-owner-type
// - repo-variable
// - repo-secret
// - github-app

// later wizard steps
// - copilot-auth
// - commit-and-push
// - handoff

Run URL: https://github.com/github/gh-aw/actions/runs/29984131428

Generated by 👨‍🍳 PR Sous Chef · gpt54 16.7 AIC · ⌖ 9.04 AIC · ⊞ 7K ·
Comment /souschef to run again

Copilot AI and others added 2 commits July 23, 2026 05:04
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix recognition of manifest config in gh aw add-wizard Surface aw.yml config during add-wizard before generic engine setup Jul 23, 2026
Copilot AI requested a review from mnkiefer July 23, 2026 05:25
@mnkiefer

Copy link
Copy Markdown
Collaborator

@copilot Compare to entry point of gh aw add. Confirm consistency in tooling.

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Compare to entry point of gh aw add. Confirm consistency in tooling.

Addressed in 12e14f5. I compared the add-wizard entry point with gh aw add and aligned the security-scanner flag wiring so add-wizard now also accepts the deprecated --disable-security-scanner alias and maps it to the same behavior.

@mnkiefer
mnkiefer marked this pull request as ready for review July 23, 2026 05:53
Copilot AI review requested due to automatic review settings July 23, 2026 05:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds manifest-driven setup phases to add-wizard, running package-specific configuration before generic engine selection.

Changes:

  • Splits bootstrap actions into pre- and post-install phases.
  • Integrates both phases into the wizard flow.
  • Adds regression tests and a deprecated security-scanner flag alias.
Show a summary per file
File Description
pkg/cli/add_interactive_orchestrator.go Executes bootstrap phases around installation.
pkg/cli/bootstrap_config.go Filters bootstrap actions by phase.
pkg/cli/bootstrap_profile_runner_test.go Tests filtering and immutability.
pkg/cli/add_wizard_command.go Adds deprecated flag alias.
pkg/cli/add_wizard_command_test.go Verifies alias deprecation.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment thread pkg/cli/add_interactive_orchestrator.go Outdated
Comment thread pkg/cli/bootstrap_config.go
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks once the branch is up to date.

Unresolved review feedback:

Generated by 👨‍🍳 PR Sous Chef · gpt54 16.7 AIC · ⌖ 9.04 AIC · ⊞ 7K ·
Comment /souschef to run again

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…config-recognition

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Copilot AI requested a review from gh-aw-bot July 23, 2026 06:39
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot add integration tests to cover these scenarios

@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage

Field Value
Category feature
Risk 🔴 High
Priority Score 62/100
Recommended Action fast_track

Score Breakdown: Impact 35 · Urgency 15 · Quality 12

Surfaces aw.yml manifest config during add-wizard before generic engine selection — meaningful UX improvement for package onboarding. Active review from @pelikhan and @mnkiefer. Pending: unresolved review threads + integration tests requested. Fast-track for human review once those items are addressed.

Generated by 🔧 PR Triage Agent · sonnet46 33.1 AIC · ⌖ 7.95 AIC · ⊞ 5.7K ·

@pelikhan
pelikhan merged commit a49df6a into main Jul 23, 2026
23 of 24 checks passed
@pelikhan
pelikhan deleted the copilot/fix-manifest-config-recognition branch July 23, 2026 07:10
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.83.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed recognition of manifest config in gh aw add-wizard

5 participants