Surface aw.yml config during add-wizard before generic engine setup#47462
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot Compare to entry point of |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Addressed in 12e14f5. I compared the |
There was a problem hiding this comment.
Pull request overview
Adds manifest-driven setup phases to add-wizard, running package-specific configuration before generic engine selection.
Changes:
- Splits bootstrap actions into pre- and post-install phases.
- Integrates both phases into the wizard flow.
- Adds regression tests and a deprecated security-scanner flag alias.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/add_interactive_orchestrator.go |
Executes bootstrap phases around installation. |
pkg/cli/bootstrap_config.go |
Filters bootstrap actions by phase. |
pkg/cli/bootstrap_profile_runner_test.go |
Tests filtering and immutability. |
pkg/cli/add_wizard_command.go |
Adds deprecated flag alias. |
pkg/cli/add_wizard_command_test.go |
Verifies alias deprecation. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Medium
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot please run the Unresolved review feedback:
|
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…config-recognition Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
@copilot add integration tests to cover these scenarios |
🤖 PR Triage
Score Breakdown: Impact 35 · Urgency 15 · Quality 12 Surfaces
|
|
🎉 This pull request is included in a new release. Release: |
gh aw addalready detected packages that declareaw.ymlconfigand redirected users toadd-wizard, butadd-wizardstill entered the default engine-selection flow instead of honoring manifest-defined interactive setup. This change makes the wizard recognize manifest config early enough to run the intended package-specific prompts.Wizard flow
add-wizard.Config phase split
require-owner-type,repo-variable,repo-secret,github-appcopilot-auth,commit-and-push,handoffBootstrap profile filtering
nilwhen no actions survive filtering, so callers naturally skip empty phases.Regression coverage
gh aw add-wizard#47461Run URL: https://github.com/github/gh-aw/actions/runs/29984131428