Add CI guard to assert pkg/cli and pkg/console unit tests are executed#47905
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
Validate pkg/cli and pkg/console tests still execute in CI
Add CI guard to assert pkg/cli and pkg/console unit tests are executed
Jul 25, 2026
Copilot created this pull request from a session on behalf of
pelikhan
July 25, 2026 03:47
View session
pelikhan
approved these changes
Jul 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI guard ensuring pkg/cli and pkg/console unit tests produce execution records.
Changes:
- Scans existing Go JSON test results for both packages.
- Fails the cgo test job when either package lacks test execution records.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds the package test-execution assertion. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #47865 introduced package-level
TestMainchanges (goleak) inpkg/cliandpkg/console; this update adds an explicit CI assertion that those package tests are still actually running. The goal is to fail fast if test discovery/execution regresses while the workflow still appears green.Unit test execution guard (cgo workflow)
.github/workflows/cgo.ymlafter unit test execution.test-result-unit.jsonforAction:"run"records for:github.com/github/gh-aw/pkg/cligithub.com/github/gh-aw/pkg/consoleScope and behavior
go test -jsonoutput generated by the workflow.