[log] Add debug logging to un-logged pkg files#47909
Merged
pelikhan merged 1 commit intoJul 25, 2026
Merged
Conversation
Add per-file namespace loggers to three genuinely un-logged files that
carry real branching logic:
- workflow/mcp_setup_scripts.go: log setup entry, tool-file count, and
per-tool script language (js/sh/py/go)
- cli/release_candidates.go: log compatibility-filter and newer-than-current
input/output counts
- fileutil/executable.go: log executable path validation/resolution entry,
success, and PATH lookup failures
All logger arguments are side-effect-free (lengths, bools, strings, error
values), following the existing logger.New("pkg:filename") convention.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pelikhan
deleted the
add-logging-mcp-scripts-release-executable-8c712ec7a8dd0201
branch
July 25, 2026 04:34
This was referenced Jul 25, 2026
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds debug logging to three previously un-instrumented
pkgfiles using the existingloggerpackage.Changes
pkg/cli/release_candidates.gocli:release_candidatespkg/fileutil/executable.gofileutil:executablepkg/workflow/mcp_setup_scripts.goworkflow:mcp_setup_scriptsPattern
Each file follows the same instrumentation pattern:
github.com/github/gh-aw/pkg/loggerlogger.New("<namespace>")variablePrintf/Printcalls at entry, exit, and branch pointsImpact