Tighten workflow recompile guardrails for .github/workflows/*.md edits#47962
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve guardrails for workflow authoring validation
Tighten workflow recompile guardrails for Jul 25, 2026
.github/workflows/*.md edits
Contributor
|
Hey What stands out:
The diff is tight, tests are present, and the issue (#47744) is properly linked. This is ready for review.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Clarifies repository-specific workflow recompilation requirements to prevent stale lock-file CI failures.
Changes:
- Adds actionable
make recompileguidance to drift checks. - Extends shell tests for remediation messaging.
- Updates contributor and workflow-editing documentation.
Show a summary per file
| File | Description |
|---|---|
scripts/check-workflow-drift.sh |
Improves compile and drift failure guidance. |
scripts/check-workflow-drift_test.sh |
Tests the updated reminders. |
scripts/check-stale-lock-files.sh |
Adds explicit recompilation remediation. |
scripts/check-stale-lock-files_test.sh |
Verifies stale-lock guidance. |
docs/src/content/docs/guides/editing-workflows.md |
Documents repository-specific editing workflow. |
CONTRIBUTING.md |
Clarifies the commit-time requirement. |
actions/setup/md/workflow_recompile_issue.md |
Prefers repository compilation wrappers. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale
.lock.ymlfiles remain a common source of avoidable CI failures after workflow markdown edits. This change makes the recompile expectation explicit in both enforcement paths and contributor guidance so drift is easier to catch and fix immediately.Guardrail messaging
.github/workflows/*.mdchanges, runmake recompilebefore committingFocused drift-check coverage
Contributor guidance
github/gh-awcontributors should treat any workflow markdown edit as a cue to runmake recompilegh aw compile --watch --schedule-seed github/gh-awas an early-feedback loop while keepingmake recompileas the final commit-time stepExample of the updated remediation path:
make recompile git add .github/workflows/*.lock.ymlmake recompileafter markdown edits #47744