fix(require-fetch-try-catch): no-op false positive for await fetch inside directly-awaited async callback

[Copilot]

isInsideTryBlock stopped at every function boundary unconditionally, so await fetch inside an inline async callback was flagged even when the wrapping call was itself awaited inside a try block — meaning the rejection genuinely propagates to and is caught by the outer handler.

Live false positive: check_version_updates.cjs:92 — await fetch inside a withRetry(async () => {...}) callback that is awaited inside an outer try/catch.

Changes

eslint-factory/src/rules/require-fetch-try-catch.ts

• When crossing a FunctionExpression/ArrowFunctionExpression boundary, check for the directly-awaited inline callback pattern before returning false:
  • ancestors[i-1] is a CallExpression, and
  • ancestors[i-2] is an AwaitExpression that is itself inside a try block with a handler
• FunctionDeclaration still always stops the walk (cannot be an inline argument)
• Updated the comment on the function boundary stop to clarify it applies to non-awaited (fire-and-forget) callbacks only

eslint-factory/src/rules/require-fetch-try-catch.test.ts

• Added valid test cases for the directly-awaited callback pattern (arrow function, function expression, IIFE)
• All three existing invalid cases (stored arrow, stored function expression, named function declaration + setTimeout) remain invalid

// now VALID — rejection propagates through the awaited chain to the outer catch
try {
  config = await withRetry(async () => {
    const res = await fetch(CONFIG_URL); // no longer flagged
    ...
  });
} catch (err) { ... }

// still INVALID — fire-and-forget; outer try cannot catch
try {
  const later = async () => { const r = await fetch(url); };
} catch (e) {}

• Fixes require-fetch-try-catch: false positive on await fetch inside an async callback that is itself awaited within an enclosing try [Content truncated due to length] #47931

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.98 AIC · ⌖ 8.65 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

[Copilot]

Pull request overview

Refines the fetch safety rule to recognize awaited inline callbacks within try/catch.

Changes:

• Detects directly awaited callback wrappers and IIFEs.
• Adds valid cases for the new behavior.
• Preserves existing invalid nested-function cases.

Show a summary per file

File	Description
eslint-factory/src/rules/require-fetch-try-catch.ts	Adds awaited-callback boundary handling.
eslint-factory/src/rules/require-fetch-try-catch.test.ts	Adds valid callback and IIFE tests.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Medium

[pelikhan]

@copilot run pr-finisherskill

[gh-aw-bot]

@copilot please run the pr-finisher skill, make sure the branch is up to date, and address any remaining review feedback or follow-up comments before rerunning checks.

Run: https://github.com/github/gh-aw/actions/runs/30155206984

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.98 AIC · ⌖ 8.65 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.83.3