Enforce appendoneelement, timenowsub, and stringsjoinone linters in CI#47970
Merged
Conversation
5 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enforce readiness for three clean autofix linters
Enforce appendoneelement, timenowsub, and stringsjoinone linters in CI
Jul 25, 2026
pelikhan
marked this pull request as ready for review
July 25, 2026 09:54
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces three existing custom Go analyzers in CI to prevent regressions in production code.
Changes:
- Enables
appendoneelement,timenowsub, andstringsjoinone. - Applies enforcement to default and WebAssembly builds.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds the three analyzer flags to both custom-linter CI invocations. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three registered analyzers —
appendoneelement,timenowsub,stringsjoinone— were advisory-only despite being fully type-resolved, autofix-verified, and having zero production violations. Without enforcement, regressions could merge silently.Changes
.github/workflows/cgo.yml: Added-appendoneelement -timenowsub -stringsjoinonetoLINTER_FLAGSin both the default build (line 1227) andGOOS=js GOARCH=wasmbuild (line 1230).These analyzers catch:
appendoneelement:append(s, []T{x}...)→append(s, x)timenowsub:time.Now().Sub(t)→time.Since(t)stringsjoinone:strings.Join([]string{s}, sep)→s