fix(daily-github-docs-seo-optimizer): allow bash to unblock safeoutputs and sub-agents#47979
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix permission denied issues in daily GitHub Docs SEO optimizer
fix(daily-github-docs-seo-optimizer): allow bash to unblock safeoutputs and sub-agents
Jul 25, 2026
pelikhan
marked this pull request as ready for review
July 25, 2026 11:12
Copilot stopped reviewing on behalf of
pelikhan due to an error
July 25, 2026 11:12
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
This PR updates the “Daily GitHub Docs SEO Optimizer” workflow configuration to broaden tool permissions and regenerates the corresponding lockfile, alongside minor formatting changes in an ESLint rule.
Changes:
- Expand workflow tool permissions (enable
bashbroadly; switch Copilot SDK args to--allow-all-tools). - Regenerate workflow lockfile metadata (updated hashes / container digest).
- Reformat conditional checks in
require-fetch-try-catchrule into single-line expressions.
Show a summary per file
| File | Description |
|---|---|
| eslint-factory/src/rules/require-fetch-try-catch.ts | Collapses multi-line if conditions into single lines. |
| .github/workflows/daily-github-docs-seo-optimizer.md | Changes tool policy to allow bash via wildcard. |
| .github/workflows/daily-github-docs-seo-optimizer.lock.yml | Regenerates lockfile and changes Copilot SDK tool-allow policy to --allow-all-tools plus image digest updates. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 4
- Review effort level: Low
| ancestors[i - 1].type === AST_NODE_TYPES.CallExpression && | ||
| ancestors[i - 2].type === AST_NODE_TYPES.AwaitExpression | ||
| ) { | ||
| if (i >= 2 && ancestors[i - 1].type === AST_NODE_TYPES.CallExpression && ancestors[i - 2].type === AST_NODE_TYPES.AwaitExpression) { |
| outerAwait.range[0] >= block.range[0] && | ||
| outerAwait.range[1] <= block.range[1] | ||
| ) { | ||
| if (outerAwait.range != null && block.range != null && outerAwait.range[0] >= block.range[0] && outerAwait.range[1] <= block.range[1]) { |
| tools: | ||
| github: false | ||
| bash: false | ||
| bash: ["*"] |
Comment on lines
731
to
735
| COPILOT_MODEL: gpt-5.4 | ||
| COPILOT_SDK_URI: http://127.0.0.1:3002 | ||
| GH_AW_COPILOT_SDK_DRIVER: 1 | ||
| GH_AW_COPILOT_SDK_SERVER_ARGS: '["--headless","--no-auto-update","--port","3002","--add-dir","/tmp/gh-aw/","--log-level","all","--log-dir","/tmp/gh-aw/sandbox/agent/logs/","--disable-builtin-mcps","--no-ask-user","--allow-tool","safeoutputs","--allow-tool","write","--no-custom-instructions"]' | ||
| GH_AW_COPILOT_SDK_SERVER_ARGS: '["--headless","--no-auto-update","--port","3002","--add-dir","/tmp/gh-aw/","--log-level","all","--log-dir","/tmp/gh-aw/sandbox/agent/logs/","--disable-builtin-mcps","--no-ask-user","--allow-all-tools","--no-custom-instructions"]' | ||
| GH_AW_LLM_PROVIDER: github |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow had
bash: false, blocking the agent from callingsafeoutputsandautomation-request-generatorvia shell — causing repeated permission denials and engine termination.Changes
daily-github-docs-seo-optimizer.md:bash: false→bash: ["*"]schedule/workflow_dispatchonly with no untrusted user inputdaily-github-docs-seo-optimizer.lock.yml: recompiled from updated source