fix(workflow): set engine.mcp.tool-timeout on daily-safe-output-optimizer - #49006
Conversation
The daily-safe-output-optimizer workflow was failing because the MCP gateway enforces a default 60-second per-tool RPC deadline. The agenticworkflows logs MCP tool timed out at ~60s on every invocation regardless of the timeout parameter passed to it. Root cause: engine.mcp.tool-timeout was not set in the workflow frontmatter, so the MCP gateway used its built-in 60s default. The logs tool needs several minutes to download workflow run artifacts. Fix: expand engine: claude to the full engine block and add engine.mcp.tool-timeout: 10m, matching the pattern already used by safe-output-health.md, audit-workflows.md, api-consumption-report.md, and detection-analysis-report.md. The compiled lock file now contains "toolTimeout": 600 in the gateway config section. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Triage: fix(workflow): set engine.mcp.tool-timeout
|
|
Warning threat detection engine error DetailsThe threat detection engine failed to produce results. Review the workflow run logs for details. 🎯 Great work fixing the timeout issue! This PR addresses the root cause identified in #48982 where the MCP gateway's 60-second RPC deadline was preventing the What looks good:
On test coverage: For infrastructure/workflow configuration changes like this, manual verification that the workflow runs successfully (without timeout) is the appropriate validation, which can be observed once this merges and the workflow runs again. This PR is ready for review! Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
|
There was a problem hiding this comment.
Pull request overview
Configures a 10-minute MCP gateway tool deadline so log analysis can complete without the previous 60-second timeout.
Changes:
- Adds
engine.mcp.tool-timeout: 10m. - Regenerates the compiled workflow with
toolTimeout: 600.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/daily-safe-output-optimizer.md |
Configures the longer MCP tool timeout. |
.github/workflows/daily-safe-output-optimizer.lock.yml |
Applies the timeout to the generated gateway configuration. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
The
daily-safe-output-optimizerworkflow was consistently failing because the MCP gateway enforces a default 60 s per-tool RPC deadline. Every invocation of theagenticworkflows logstool timed out at ~60 s regardless of thetimeoutparameter passed—that parameter only governs the subprocess deadline, not the gateway-level one.Changes
daily-safe-output-optimizer.md: Expandedengine: claudeto the full block and addedengine.mcp.tool-timeout: 10m, matching the existing pattern insafe-output-health.md,audit-workflows.md,api-consumption-report.md, anddetection-analysis-report.md.The compiled lock file now emits
"toolTimeout": 600in the gateway config section, giving thelogstool enough headroom to download 24 h of workflow run artifacts before the gateway closes the connection.