Handle persona-explorer invocation failures as first-class partial results - #49413
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix threat detection engine error for persona exploration
Handle persona-explorer invocation failures as first-class partial results
Jul 31, 2026
pelikhan
approved these changes
Aug 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates persona evaluation guidance to treat unavailable custom-agent invocations as partial results with unavailable scoring.
Changes:
- Adds recommendation-only evaluation phrasing and fallback guidance.
- Defines
invocation_unavailableandN/Ascoring behavior. - Updates the compiled workflow metadata.
Show a summary per file
| File | Description |
|---|---|
.github/aw/create-agentic-workflow.md |
Adds fallback evaluation guidance. |
.github/aw/github-agentic-workflows.md |
Adds explicit research invocation phrasing. |
.github/workflows/agent-persona-explorer.md |
Defines partial-result and scoring behavior. |
.github/workflows/agent-persona-explorer.lock.yml |
Updates the generated body hash. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Suppressed comments (1)
.github/workflows/agent-persona-explorer.md:225
- This leaves mixed-success reporting ambiguous: line 179 requires averaging the successfully scored scenarios, while this placeholder permits
N/Awhenever any invocation is unavailable. The preceding field also conflates the 3–4 selected scenarios with scenarios that actually returned a response, which would misreport an all-unavailable run as tested. Separate the counts and useN/Aonly when no scenarios were scored.
- **Average Quality Score**: [X.X/5.0 or N/A when invocation/scoring is unavailable]
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
| - **Keep responses focused and concise** - summarize findings instead of verbose descriptions | ||
| - Aim for quality over quantity - fewer well-analyzed scenarios are better than many shallow ones | ||
| - **If any tool call fails, record the error briefly and move on to the next scenario** - do NOT retry or get stuck | ||
| - **If any tool call fails, record the error briefly, mark scoring as unavailable for that scenario, and move on to the next scenario** - do NOT retry or get stuck |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The persona explorer run surfaced a tooling failure in threat detection and produced useful-but-partial results without scenario scoring. This updates the workflow guidance so evaluation-mode invocation failures are treated as expected partial outcomes, with explicit
N/Ascoring semantics.Ad hoc evaluation invocation guidance
.github/aw/github-agentic-workflows.mdto add explicit research/evaluation invocation phrasing for no-file-creation mode.agentic-workflows.Fallback evaluation behavior when custom-agent invocation is unavailable
.github/aw/create-agentic-workflow.mdto define fallback behavior:Persona explorer partial-results scoring contract
.github/workflows/agent-persona-explorer.mdto standardize failure handling:invocation_unavailable,N/A,Average Quality Scoreto beN/Awhen scoring is unavailable,