Promote five custom analyzers to enforced linter gates - #49471
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Test Quality Sentinel completed test quality analysis. Warning threat detection engine error DetailsThe threat detection engine failed to produce results. Review the workflow run logs for details. No test files were added or modified in this PR. Test Quality Sentinel skipped. |
There was a problem hiding this comment.
🟢 Ready to approve
The analyzer names are registered, and both CI gates are updated consistently as requested.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Enforces five clean, registered custom analyzers in CI for default and WASM builds.
Changes:
- Adds all five analyzer flags to both custom-linter gates.
- Retains production-only analysis with
-test=false.
File summaries
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Enables five additional analyzers in default and WASM lint gates. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ Warning threat detection engine error DetailsThe threat detection engine failed to produce results. Review the workflow run logs for details. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the implementation label and has 0 new lines of code in business logic directories (threshold: 100). |
|
✅ PR Code Quality Reviewer completed the code quality review. Warning threat detection engine error DetailsThe threat detection engine failed to produce results. Review the workflow run logs for details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.
Details
The threat detection engine failed to produce results.
Review the workflow run logs for details.
Verdict: Approve — no blocking issues
This is a low-risk, mechanical change: appends five already-implemented and registered custom analyzer flags (writebytestring, lenstringsplit, stringreplaceminusone, osgetenvlibrary, ossetenvlibrary) to the CI LINTER_FLAGS in both the default-build and wasm gates.
Review notes
- Verified all five analyzer packages exist under
pkg/linters/and are wired intopkg/linters/registry.go. - Both gate invocations (default and
GOOS=js GOARCH=wasm) were updated consistently, keeping the two flag lists in sync as required. - PR description states these produce zero findings against the current codebase, so no unexpected CI failures are expected from this change alone.
- No logic, security, or maintainability concerns found in the diff — it is purely additive flag enforcement.
🔎 Code quality review by PR Code Quality Reviewer · auto · 9.2 AIC · ⊞ 7.8K
Comment /review to run again
|
Warning threat detection engine error DetailsThe threat detection engine failed to produce results. Review the workflow run logs for details. 🧪 Test Quality Sentinel Report✅ Test Quality Score: N/A — No Tests
📊 Analysis Summary
Verdict
|
There was a problem hiding this comment.
Warning
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.
Details
The threat detection engine failed to produce results.
Review the workflow run logs for details.
Skills-Based Review 🧠
Applied /codebase-design — changes are clean and consistent.
📋 Summary
Positive Highlights
- ✅ Both CI gates (
Run custom lintersandRun custom linters (wasm)) updated symmetrically — no drift between environments - ✅ Flags appended just before
-test=false, preserving the sentinel position - ✅ Five new analyzers (
writebytestring,lenstringsplit,stringreplaceminusone,osgetenvlibrary,ossetenvlibrary) gated consistently - ✅ PR description clearly explains the rationale (zero findings confirms safe promotion)
No actionable issues found.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 16.9 AIC · ⊞ 7K
Comment /matt to run again
There was a problem hiding this comment.
Warning
threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.
Details
The threat detection engine failed to produce results.
Review the workflow run logs for details.
The change is correct and consistent: five analyzer flags are added before -test=false in both the default and GOOS=js GOARCH=wasm linter gate invocations. The ordering is symmetric and no flag is omitted from either line. Nothing blocking.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 13.1 AIC · ⊞ 5.3K
|
🎉 This pull request is included in a new release. Release: |
Five registered custom analyzers (
writebytestring,lenstringsplit,stringreplaceminusone,osgetenvlibrary,ossetenvlibrary) were absent from the CI enforcement gate despite producing zero findings against the current codebase.Changes
.github/workflows/cgo.yml— append all five flags toLINTER_FLAGSin both the default-build gate (line 1362) and theGOOS=js GOARCH=wasmgate (line 1365):