Stabilize go-logger workflow toolchain resolution - #49473
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Warning threat detection engine error DetailsThe threat detection engine failed to produce results. Review the workflow run logs for details. Hey I notice this PR is still in draft status with no file changes yet. Here are a few things to keep in mind as you move forward:
Once you've made these changes and moved the PR out of draft status, it should be ready for review. Keep up the work!
|
There was a problem hiding this comment.
Pull request overview
Stabilizes Go Logger validation by allowing automatic resolution of the Go 1.26.5 toolchain, addressing #49465.
Changes:
- Enables
GOTOOLCHAIN: auto. - Allows Go ecosystem network domains.
- Recompiles the generated workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/go-logger.md |
Configures toolchain and network access. |
.github/workflows/go-logger.lock.yml |
Carries the configuration into GitHub Actions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
|
🎉 This pull request is included in a new release. Release: |
The Go Logger Enhancement workflow was failing during agent-side validation because the job could run with
GOTOOLCHAIN=localwhilego.modnow requires Go 1.26.5. Once validation failed, the agent drifted into runner-specific Go path probing instead of staying on the logging task.Toolchain setup
GOTOOLCHAIN: autoat the workflow level so agent validation commands can resolve the required Go toolchain without manual environment mutation.Network allowlist
goecosystem domain set to the workflow network policy so automatic toolchain/module resolution is permitted inside the sandbox.Compiled workflow update
go-logger.lock.ymlto carry the env and network changes into the generated Actions workflow.