Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dependabot Docker update coverage for container image supply chain #49528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dependabot Docker update coverage for container image supply chain #49528
Changes from all commits
75575861a1cdf6d442752827795cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
directory: /actions/setup/jsentry targets a directory that contains onlyDockerfile.safe-outputs-mcp, not a file namedDockerfile. Dependabot's Docker ecosystem scanner looks for files named exactlyDockerfileby default — a non-standard name likeDockerfile.safe-outputs-mcpwill not be picked up, so this entry will either produce a Dependabot config error or silently yield no updates.Consider one of:
Dockerfile.safe-outputs-mcptoDockerfileif it is the only Docker artifact in that directory.Dockerfileexists in/actions/setup/js.@copilot please address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/codebase-design] The Dockerfile in
/actions/setup/jsis namedDockerfile.safe-outputs-mcp, notDockerfile. Dependabot Docker scanning defaults to standard filenames; a non-standard name may silently produce no update PRs, leaving this entry ineffective.💡 Verification options
Dockerfile.safe-outputs-mcp→Dockerfileand update references in any build scripts.If this directory is silently skipped, the supply-chain coverage goal for that image is unmet.
@copilot please address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry likely produces zero update coverage: Dependabot's
dockerecosystem only detects files literally namedDockerfile/dockerfile(ordocker-compose.yml) in the target directory, but/actions/setup/jsonly containsDockerfile.safe-outputs-mcp.💡 Dependabot docker-ecosystem file detection
Dependabot's docker-ecosystem scanner does not glob or pattern-match arbitrary Dockerfile names — it looks for an exact
Dockerfile/dockerfileordocker-compose.ymlin the configureddirectory. The only Docker-related file inactions/setup/js/isDockerfile.safe-outputs-mcp, which will not be picked up.Impact: this new entry silently produces no update PRs, defeating the PR's stated goal (closing the docker CVE-remediation gap from #49168) for this specific directory.
Fix: rename the file to
Dockerfile(with the multi-stage/target distinguished via build args or a separate directory), or drop this entry until Dependabot supports custom names, and verify post-merge that a PR is actually opened for this ecosystem/directory pair.