Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,15 @@ updates:
directory: /.github/workflows
schedule:
interval: weekly
- package-ecosystem: docker
directory: /
schedule:
interval: weekly
Comment on lines +27 to +30
- package-ecosystem: docker
directory: /actions/setup/js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory: /actions/setup/js entry targets a directory that contains only Dockerfile.safe-outputs-mcp, not a file named Dockerfile. Dependabot's Docker ecosystem scanner looks for files named exactly Dockerfile by default — a non-standard name like Dockerfile.safe-outputs-mcp will not be picked up, so this entry will either produce a Dependabot config error or silently yield no updates.

Consider one of:

  1. Rename Dockerfile.safe-outputs-mcp to Dockerfile if it is the only Docker artifact in that directory.
  2. Remove this entry until a standard Dockerfile exists in /actions/setup/js.

@copilot please address this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/codebase-design] The Dockerfile in /actions/setup/js is named Dockerfile.safe-outputs-mcp, not Dockerfile. Dependabot Docker scanning defaults to standard filenames; a non-standard name may silently produce no update PRs, leaving this entry ineffective.

💡 Verification options
  1. After merge, check Dependabot logs to confirm the directory triggers Docker update PRs.
  2. Rename Dockerfile.safe-outputs-mcpDockerfile and update references in any build scripts.
  3. If renaming is undesirable, verify Dependabot's documentation for custom Dockerfile name support.

If this directory is silently skipped, the supply-chain coverage goal for that image is unmet.

@copilot please address this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry likely produces zero update coverage: Dependabot's docker ecosystem only detects files literally named Dockerfile/dockerfile (or docker-compose.yml) in the target directory, but /actions/setup/js only contains Dockerfile.safe-outputs-mcp.

💡 Dependabot docker-ecosystem file detection

Dependabot's docker-ecosystem scanner does not glob or pattern-match arbitrary Dockerfile names — it looks for an exact Dockerfile/dockerfile or docker-compose.yml in the configured directory. The only Docker-related file in actions/setup/js/ is Dockerfile.safe-outputs-mcp, which will not be picked up.

Impact: this new entry silently produces no update PRs, defeating the PR's stated goal (closing the docker CVE-remediation gap from #49168) for this specific directory.

Fix: rename the file to Dockerfile (with the multi-stage/target distinguished via build args or a separate directory), or drop this entry until Dependabot supports custom names, and verify post-merge that a PR is actually opened for this ecosystem/directory pair.

schedule:
interval: weekly
Comment on lines +31 to +34
- package-ecosystem: docker
directory: /.devcontainer
schedule:
interval: weekly