Drop "cancelled" from FAILURE_CONCLUSIONS in aw-failure-investigator - #49658
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Drop 'cancelled' from FAILURE_CONCLUSIONS to reduce false positives
Drop "cancelled" from FAILURE_CONCLUSIONS in aw-failure-investigator
Aug 1, 2026
pelikhan
marked this pull request as ready for review
August 1, 2026 22:35
Contributor
There was a problem hiding this comment.
Pull request overview
Excludes cancelled workflow runs from failure investigation, reducing false positives during concurrency cancellations.
Changes:
- Removes
cancelledfrom failure conclusions. - Recompiles the investigator workflow.
- Includes unrelated detection-model changes in two generated workflows.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/aw-failure-investigator.md |
Updates failure filtering. |
.github/workflows/aw-failure-investigator.lock.yml |
Regenerates the compiled workflow. |
.github/workflows/smoke-checkout-pr-dispatch.lock.yml |
Changes detection-model routing. |
.github/workflows/daily-arxiv-researcher.lock.yml |
Changes detection-model routing. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Balanced
| TRACKER_ID = "aw-failure-investigator" | ||
| LOOKBACK_HOURS = 6 | ||
| FAILURE_CONCLUSIONS = {"failure", "timed_out", "startup_failure", "cancelled"} | ||
| FAILURE_CONCLUSIONS = {"failure", "timed_out", "startup_failure"} |
| -- /bin/bash -c 'set +o histexpand; : "${RUNNER_TOOL_CACHE:?RUNNER_TOOL_CACHE must be set}"; GH_AW_TOOL_CACHE="$RUNNER_TOOL_CACHE"; export PATH="$(find "$GH_AW_TOOL_CACHE" -maxdepth 5 -type d -name bin 2>/dev/null | tr '\''\n'\'' '\'':'\'')$PATH"; [ -n "$GOROOT" ] && export PATH="$GOROOT/bin:$PATH" || true; [ -n "$ERLANG_HOME" ] && export PATH="$ERLANG_HOME/bin:$PATH" || true && GH_AW_NODE_EXEC="${GH_AW_NODE_BIN:-}"; if [ -z "$GH_AW_NODE_EXEC" ] || [ ! -x "$GH_AW_NODE_EXEC" ]; then GH_AW_NODE_EXEC="$(command -v node 2>/dev/null || true)"; fi; if [ -z "$GH_AW_NODE_EXEC" ]; then echo "node runtime missing on this runner — check runtimes.node in workflow YAML" >&2; exit 127; fi; GH_AW_NPM_GLOBAL_ROOT="$(npm root -g 2>/dev/null || true)"; if [ -n "$GH_AW_NPM_GLOBAL_ROOT" ]; then export NODE_PATH="${GH_AW_NPM_GLOBAL_ROOT}${NODE_PATH:+:${NODE_PATH}}"; fi; "$GH_AW_NODE_EXEC" ${RUNNER_TEMP}/gh-aw/actions/claude_harness.cjs claude --print --no-chrome --allowed-tools '\''Bash,BashOutput,Edit(/tmp/*),ExitPlanMode,Glob,Grep,KillBash,LS,MultiEdit(/tmp/*),NotebookRead,Read,Read(/tmp/*),Task,TodoWrite,Write(/tmp/*)'\'' --debug-file /tmp/gh-aw/threat-detection/detection.log --verbose --permission-mode acceptEdits --output-format stream-json --prompt-file /tmp/gh-aw/aw-prompts/prompt.txt' 2>&1 | tee -a /tmp/gh-aw/threat-detection/detection.log | ||
| env: | ||
| ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }} | ||
| ANTHROPIC_MODEL: detection |
| COPILOT_DUMMY_BYOK: dummy-byok-key-for-offline-mode | ||
| COPILOT_GITHUB_TOKEN: ${{ secrets.COPILOT_GITHUB_TOKEN }} | ||
| COPILOT_MODEL: ${{ vars.GH_AW_MODEL_DETECTION_COPILOT || vars.GH_AW_DEFAULT_MODEL_COPILOT || 'auto' }} | ||
| COPILOT_MODEL: detection |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot bulk-PR bursts cause GitHub Actions to cancel concurrency-group runs in <2s with zero agent activity, flooding the failure investigator with false positives (60+ phantom failures per burst, burying the 3 real ones).
Change
aw-failure-investigator.md: Remove"cancelled"from theFAILURE_CONCLUSIONSset; only"failure","timed_out", and"startup_failure"represent genuine regressions worth investigating.aw-failure-investigator.lock.yml: Recompiled to match.