Skip to content

Disable vulnerable mcp/notion container integration (Critical/High CVEs, no upstream fix) - #49805

Merged
pelikhan merged 6 commits into
mainfrom
copilot/container-image-scan-mcp-notion
Aug 2, 2026
Merged

Disable vulnerable mcp/notion container integration (Critical/High CVEs, no upstream fix)#49805
pelikhan merged 6 commits into
mainfrom
copilot/container-image-scan-mcp-notion

Conversation

Copilot AI commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

docker.io/mcp/notion carries 258 vulnerabilities (11 Critical, 74 High) including stdlib Go and glibc issues. Docker Hub has only one tag (latest) — no patched image exists upstream.

Applies the same remediation pattern used for mcp/brave-search (#48546):

  • shared/mcp/notion.md — stripped mcp-servers and safe-outputs blocks; replaced with a security comment referencing the issue and instructions for re-enabling once a patched image lands
  • mcp-inspector.md — commented out shared/mcp/notion.md import with a CVE note (mirrors the brave.md exclusion comment)
  • actions-lock.json + both action_pins.json mirrors — removed the mcp/notion container pin entry
  • All 268 workflows recompiledmcp/notion@sha256:df0d6781... is no longer referenced in any .lock.yml; NOTION_API_TOKEN dropped from compiled manifests
# mcp-inspector.md — before
  - shared/mcp/notion.md

# mcp-inspector.md — after
  # Note: notion.md excluded — docker.io/mcp/notion has Critical/High CVEs (see #49517)

…tion

docker.io/mcp/notion has Critical/High CVEs with no upstream fix available.
Follows the same pattern used for mcp/brave-search (issue #48546).

- Gut shared/mcp/notion.md container definition, add security comment
- Comment out notion.md import in mcp-inspector.md (like brave.md)
- Remove mcp/notion pin from actions-lock.json and both action_pins.json mirrors
- Recompile all 268 workflows; mcp/notion SHA no longer appears in any lock file

Closes #49517

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update container image mcp/notion to address vulnerabilities Disable vulnerable mcp/notion container integration (Critical/High CVEs, no upstream fix) Aug 2, 2026
Copilot AI requested a review from pelikhan August 2, 2026 15:56
@pelikhan
pelikhan marked this pull request as ready for review August 2, 2026 16:02
Copilot AI review requested due to automatic review settings August 2, 2026 16:02
@pelikhan

pelikhan commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the vulnerable mcp/notion container integration pending an upstream fix.

Changes:

  • Removes the Notion container configuration and image pins.
  • Excludes Notion from MCP Inspector.
  • Regenerates affected workflow lock files.
Show a summary per file
File Description
.github/aw/actions-lock.json Removes the Notion image pin.
.github/workflows/mcp-inspector.md Excludes the Notion integration.
.github/workflows/mcp-inspector.lock.yml Regenerates MCP Inspector without Notion.
.github/workflows/notion-issue-summary.lock.yml Regenerates the summary workflow without Notion.
.github/workflows/shared/mcp/notion.md Disables the shared integration.
pkg/actionpins/data/action_pins.json Removes the runtime pin mirror.
pkg/workflow/data/action_pins.json Removes the compiler pin mirror.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

# Notion MCP Server
# SECURITY: docker.io/mcp/notion has Critical/High CVEs with no upstream fix available (issue #49517).
# The container definition has been removed until a patched image is published upstream.
# To re-enable, restore the mcp-servers and safe-outputs blocks and update the pinned digest in actions-lock.json.
Copilot AI and others added 2 commits August 2, 2026 16:13
…ge-scan-mcp-notion

# Conflicts:
#	.github/workflows/mcp-inspector.lock.yml

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…h markitdown and notion)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts on this branch.

Resolved. The conflict was in .github/workflows/mcp-inspector.lock.yml — main had removed mcp/markitdown (PR #49806) while our branch had removed mcp/notion. The source file mcp-inspector.md auto-merged correctly with both exclusions. I resolved the lock file conflict and recompiled all 268 workflows. The regenerated lock file now references neither mcp/notion nor mcp/markitdown.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot This PR has merge conflicts. Please run make merge-main to resolve conflicts, then continue with the pr-finisher skill.

Run details: https://github.com/github/gh-aw/actions/runs/30756126865

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.4 AIC · ⌖ 6.61 AIC · ⊞ 8.3K ·
Comment /souschef to run again

…ge-scan-mcp-notion

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot This PR has merge conflicts. Please run make merge-main to resolve conflicts, then continue with the pr-finisher skill.

Run details: https://github.com/github/gh-aw/actions/runs/30756126...

Merged main (commit 9eb50e1 — typeutil refactor) with no conflicts. All 268 workflows compile and lock files are in sync.

Copilot AI requested a review from gh-aw-bot August 2, 2026 16:29
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot This PR has merge conflicts. Please run make merge-main to resolve conflicts, then continue with the pr-finisher skill.

Run details: https://github.com/github/gh-aw/actions/runs/30757146330

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13.8 AIC · ⌖ 6.26 AIC · ⊞ 5.9K ·
Comment /souschef to run again

…ge-scan-mcp-notion

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot This PR has merge conflicts. Please run make merge-main to resolve conflicts, then continue with the pr-finisher skill.

Run details: https://github.com/github/gh-aw/actions/runs/30757146...

Merged latest main (fe1ccb6 — watchdog authentication fix) with no conflicts. All 268 workflows compile and lock files are in sync.

@pelikhan
pelikhan merged commit 6c11d67 into main Aug 2, 2026
@pelikhan
pelikhan deleted the copilot/container-image-scan-mcp-notion branch August 2, 2026 17:04
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.84.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[container-image-scan] Container findings for mcp/notion

4 participants