fix: support ready_for_review activity type in pull_request_target trigger - #49865
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
ready_for_review activity type in pull_request_target trigger
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped. |
There was a problem hiding this comment.
Pull request overview
Adds schema support for ready_for_review in pull_request_target triggers.
Changes:
- Extends the trigger activity enum.
- Adds regression coverage.
- Documents the fix in a patch changeset.
Show a summary per file
| File | Description |
|---|---|
pkg/parser/schemas/main_workflow_schema.json |
Allows ready_for_review. |
pkg/parser/schema_location_test.go |
Tests schema acceptance. |
.changeset/fix-ready-for-review-pull-request-target.md |
Adds release documentation. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| "gh-aw": patch | ||
| --- | ||
|
|
||
| Fixed `ready_for_review` activity type not being accepted in `on.pull_request_target.types`. The schema now allows the same activity types for `pull_request_target` as for `pull_request`, including `ready_for_review`. |
|
@copilot Fix the code for all comments in this review thread. When a review comment includes a suggested change, apply the suggestion exactly. Do not make changes beyond what is described in the linked review thread. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in de4ba28. |
|
🎉 This pull request is included in a new release. Release: |
pull_request_target.typesrejectedready_for_revieweven though it's a valid activity type forpull_request. This made it impossible to migrate workflows like:Changes
pkg/parser/schemas/main_workflow_schema.json): Addedready_for_reviewto theon.pull_request_target.typesenum, aligning it with thepull_requestevent's allowed types.pkg/parser/schema_location_test.go): Regression test forpull_request_targetwithtypes: [ready_for_review].