[log] Add debug logging to under-instrumented pkg/ files - #49896
Merged
Conversation
Adds namespaced pkg/logger loggers and log calls at meaningful control-flow points (skip conditions, validation failures, diagnostic emission, attribution results) to five files that previously had zero logging: two AST-analysis linters (logfatallibrary, rawloginlib), a CLI token-usage/docker-args validation pair, and a parser schema-alias helper.
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds
pkg/loggerdebug instrumentation to five previously under-instrumentedpkg/files. Purely additive logging change — no functional, behavioral, or API changes.Changed Files
pkg/cli/docker_args_validation.gocli:docker_args_validationpkg/cli/token_usage_subagent.gocli:token_usage_subagentpkg/linters/logfatallibrary/logfatallibrary.golinters:logfatallibrarylog.Fatal*calls.pkg/linters/rawloginlib/rawloginlib.golinters:rawloginliblogpackage calls.pkg/parser/schema_safe_output_aliases.goparser:schema_safe_output_aliasesNotes
logger.New(...)package-level var following the existing namespace convention.DEBUGnamespace is enabled (e.g.DEBUG=cli:*,DEBUG=linters:*,DEBUG=parser:*).