[aw] Prevent Layout Specification Maintainer early termination from tool-denial guardrail - #49966
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix layout specification maintainer tool denial issue
[aw] Prevent Layout Specification Maintainer early termination from tool-denial guardrail
Aug 3, 2026
pelikhan
marked this pull request as ready for review
August 3, 2026 13:02
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Layout Specification Maintainer’s shell permissions to reduce tool-denial terminations.
Changes:
- Adds allowlist entries for
sedand Git status/checkout commands. - Recompiles the generated workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/layout-spec-maintainer.md |
Expands bash permissions. |
.github/workflows/layout-spec-maintainer.lock.yml |
Synchronizes compiled permissions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Suppressed comments (1)
.github/workflows/layout-spec-maintainer.md:61
- This embedded
*is preserved in the compiledshell(...)rule, while Copilot SDK rules containing spaces are exact full-command matches. A generated branch such aslayout-spec-update-20260803therefore cannot match this literal rule, so the observed checkout/add/status sequence can still be denied and contribute to the 3/3 termination. Split the sequence into separately permitted commands, or use another SDK-matchable scoped rule rather than an embedded glob.
- git checkout -b * && git add scratchpad/layout.md && git status --short
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| - cd * && git add * && git status | ||
| - git diff scratchpad/layout.md | ||
| - cat scratchpad/layout.md | ||
| - sed -n |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Layout Specification Maintainer workflow was repeatedly failing after hitting
guard.tool_denials_exceeded (3/3), ending the agent session before it could emit results. The failures were caused by denied shell command patterns used by the workflow prompt path.Root cause addressed
Workflow source update (
.github/workflows/layout-spec-maintainer.md)sed -ngit status --shortgit checkout -b * && git add scratchpad/layout.md && git status --shortCompiled output sync (
.github/workflows/layout-spec-maintainer.lock.yml)