Skip to content

[aw] Prevent Layout Specification Maintainer early termination from tool-denial guardrail - #49966

Merged
pelikhan merged 4 commits into
mainfrom
copilot/layout-spec-update-20260803
Aug 3, 2026
Merged

[aw] Prevent Layout Specification Maintainer early termination from tool-denial guardrail#49966
pelikhan merged 4 commits into
mainfrom
copilot/layout-spec-update-20260803

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The Layout Specification Maintainer workflow was repeatedly failing after hitting guard.tool_denials_exceeded (3/3), ending the agent session before it could emit results. The failures were caused by denied shell command patterns used by the workflow prompt path.

  • Root cause addressed

    • Expanded the workflow bash allowlist to cover command forms observed in failing runs but not previously permitted.
  • Workflow source update (.github/workflows/layout-spec-maintainer.md)

    • Added explicit allowlist entries for:
      • sed -n
      • git status --short
      • git checkout -b * && git add scratchpad/layout.md && git status --short
  • Compiled output sync (.github/workflows/layout-spec-maintainer.lock.yml)

    • Recompiled lockfile so Copilot SDK tool permissions reflect the updated allowlist in runtime args.
tools:
  bash:
    - sed -n
    - git status --short
    - git checkout -b * && git add scratchpad/layout.md && git status --short

Copilot AI and others added 2 commits August 3, 2026 12:18
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix layout specification maintainer tool denial issue [aw] Prevent Layout Specification Maintainer early termination from tool-denial guardrail Aug 3, 2026
Copilot AI requested a review from pelikhan August 3, 2026 12:32
@pelikhan
pelikhan marked this pull request as ready for review August 3, 2026 13:02
Copilot AI review requested due to automatic review settings August 3, 2026 13:02
@pelikhan
pelikhan merged commit dd3a266 into main Aug 3, 2026
@pelikhan
pelikhan deleted the copilot/layout-spec-update-20260803 branch August 3, 2026 13:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Layout Specification Maintainer’s shell permissions to reduce tool-denial terminations.

Changes:

  • Adds allowlist entries for sed and Git status/checkout commands.
  • Recompiles the generated workflow.
Show a summary per file
File Description
.github/workflows/layout-spec-maintainer.md Expands bash permissions.
.github/workflows/layout-spec-maintainer.lock.yml Synchronizes compiled permissions.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Suppressed comments (1)

.github/workflows/layout-spec-maintainer.md:61

  • This embedded * is preserved in the compiled shell(...) rule, while Copilot SDK rules containing spaces are exact full-command matches. A generated branch such as layout-spec-update-20260803 therefore cannot match this literal rule, so the observed checkout/add/status sequence can still be denied and contribute to the 3/3 termination. Split the sequence into separately permitted commands, or use another SDK-matchable scoped rule rather than an embedded glob.
  - git checkout -b * && git add scratchpad/layout.md && git status --short
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

- cd * && git add * && git status
- git diff scratchpad/layout.md
- cat scratchpad/layout.md
- sed -n
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.84.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Layout Specification Maintainer exceeded tool denial limit

3 participants