Suppress ctxbackground lint in ctxutil.OrBackground

[Copilot]

The custom ctxbackground linter flagged context.Background() at pkg/ctxutil/ctxutil.go:17. The finding is a false positive: OrBackground exists specifically to substitute a background context when the passed-in context is nil, so there is no context to propagate on that branch.

Changes

• Added an inline //nolint:ctxbackground directive on the fallback return, with a short comment explaining why the parameter cannot be used there.
• No behavior change.

func OrBackground(ctx context.Context) context.Context {
	if ctx == nil {
		// The parameter is nil here, so falling back to a fresh background
		// context is the intended behavior of this helper.
		return context.Background() //nolint:ctxbackground
	}
	return ctx
}

An alternative would be to teach the linter to skip functions whose only context.Context parameter is provably nil on the flagged path, but that is broader than this finding warrants.

• Fixes [lint-monster] lint-monster: fix context propagation lint in pkg/ctxutil #50162

[Copilot]

Pull request overview

Suppresses a false-positive ctxbackground lint finding without changing behavior.

Changes:

• Documents the intentional nil-context fallback.
• Adds a targeted //nolint:ctxbackground directive.

Show a summary per file

File	Description
pkg/ctxutil/ctxutil.go	Explains and suppresses the intentional background-context fallback.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the implementation label and has ≤100 new lines of code in business logic directories (3 additions detected).

[github-actions]

Verdict: Approve — no blocking issues

Minimal, correct change: adds a //nolint:ctxbackground suppression with an explanatory comment on the intended fallback branch of OrBackground. No behavior change.

Review notes

• The nil-check branch genuinely has no context to propagate, so the lint suppression is justified rather than papering over a real issue.
• Comment text is accurate and matches the code intent.
• Diff is 3 lines, single file, no test changes needed since behavior is unchanged.
• No correctness, concurrency, security, or performance concerns found in the changed lines.

🔎 Code quality review by PR Code Quality Reviewer · auto · 12 AIC · ⌖ 4.6 AIC · ⊞ 7.9K
_{Comment /review to run again}

[github-actions]

Skills-Based Review 🧠

Applied /diagnosing-bugs — this is a clean, correct false-positive suppression with no behavioral change.

The //nolint:ctxbackground directive is properly placed and the inline comment clearly explains why context.Background() is intentional here (the parameter is provably nil on that branch). The PR description also documents the trade-off of teaching the linter vs. a local suppression, which is good engineering judgment.

✅ No issues found — approving.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 16.3 AIC · ⌖ 14.2 AIC · ⊞ 7.1K
_{Comment /matt to run again}

[github-actions]

The suppression is correct: OrBackground is the designated escape hatch for nil contexts, so the ctxbackground lint finding here is a false positive. The inline comment clearly documents the rationale. No behavioral change. LGTM.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 12.5 AIC · ⌖ 9.2 AIC · ⊞ 5.4K

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.84.4