Closed
Refactor AWF helper monolith into focused modules with preserved command/env APIs#50297
Conversation
8 tasks
Copilot
AI
changed the title
[WIP] Refactor pkg/workflow/awf_helpers.go into smaller files
Refactor AWF helper monolith into focused modules with preserved command/env APIs
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/workflow/awf_helpers.gohad become the largest non-test source file, with command assembly and feature/env/image/ARC-DinD helpers co-located. This change decomposes that surface into focused files while keeping behavior and exported interfaces stable.Module split by responsibility
awf_command.go:BuildAWFCommand,BuildAWFArgs,GetAWFCommandPrefix,WrapCommandInShellawf_arcdind.go: ARC/DinD topology detection and chroot/workflow-call network patch helpersawf_feature_support.go: AWF version-gated capability checks (awfSupports*,awfVersionAtLeast)awf_env.go: environment assembly/injection helpers (ComputeAWFExcludeEnvVarNames, token/max-credit env wiring)awf_image.go: image tag+digest resolution and model JSON path export script helpersPublic API and behavior preserved
BuildAWFCommandBuildAWFArgsGetAWFCommandPrefixWrapCommandInShellComputeAWFExcludeEnvVarNamesTest boundary alignment