Updating agentic engine frontmatter for new mcp field - #50345
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds engine-level MCP capability metadata and proxy enforcement for engines without native MCP support.
Changes:
- Adds the
engine.mcpfield and schema. - Automatically enables GitHub and CLI proxies for MCP-less engines.
- Updates and recompiles the Aider smoke workflow.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/engine_definition.go |
Adds MCP capability metadata. |
pkg/workflow/compiler_orchestrator_tools.go |
Enforces proxy tools. |
pkg/workflow/compiler_orchestrator_tools_test.go |
Tests proxy enforcement. |
pkg/parser/schemas/main_workflow_schema.json |
Defines the new schema field. |
.github/workflows/shared/aider.md |
Marks Aider as MCP-less. |
.github/workflows/smoke-aider.md |
Removes incompatible GitHub disabling. |
.github/workflows/smoke-aider.lock.yml |
Regenerates the compiled workflow. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Balanced
| if _, exists := tools["github"]; !exists { | ||
| tools["github"] = map[string]any{"mode": string(GitHubMCPModeGHProxy)} | ||
| } else if enabled, ok := tools["github"].(bool); ok && enabled { | ||
| tools["github"] = map[string]any{"mode": string(GitHubMCPModeGHProxy)} | ||
| } |
|
@copilot review the pi agent engine definition and update since it does not support MCP either. Ensure that the gh-proxy/cli-proxy enforcement is generic and using the new falg. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Implemented in 066a1ef. Pi now declares |
|
@copilot pi engine is defined in .go here https://github.com/github/gh-aw/blob/main/pkg/workflow/pi_engine.go#L45 please patch as well |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Implemented in 3472331. |
TriageCategory: feature | Risk: medium | Score: 54/100 (impact 30, urgency 12, quality 12) Recommended action: fast_track Touches core engine files (19 changed) adding a new pi agentic engine and mcp field support to frontmatter. No CI status available yet; has one reviewer comment. Given the breadth of engine-layer changes, recommend expedited human review before merge.
|
|
@copilot Please address the remaining unresolved review feedback and prepare this PR with the
Once handled, resolve the thread and leave the PR ready for maintainer verification.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
…c-engine-frontmatter Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Refreshed the branch with |
|
🎉 This pull request is included in a new release. Release: |
Pull request created by AI Agent