[WIP] Fix Smoke Aider engine termination issue - #50391
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
August 4, 2026 21:02
Collaborator
|
/smoke-aider |
pelikhan
marked this pull request as ready for review
August 4, 2026 21:19
Contributor
|
🚀 Agentic Commands has started processing this issue comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes behavior-defined engines such as Aider failing to start the MCP gateway.
Changes:
- Always renders MCP gateway startup configuration.
- Adds regression tests and recompiles Smoke Aider.
- Adds a patch changeset.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/behavior_defined_engine.go |
Adds default MCP rendering fallback. |
pkg/workflow/behavior_defined_engine_harness_test.go |
Adds MCP rendering tests. |
.github/workflows/smoke-aider.lock.yml |
Includes generated gateway startup. |
.changeset/fix-behavior-engine-mcp-gateway-startup.md |
Documents the fix. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+208
to
+210
| var sb strings.Builder | ||
| require.NoError(t, engine.RenderMCPConfig(&sb, workflowData.Tools, []string{"safe-outputs"}, workflowData)) | ||
| assert.Contains(t, sb.String(), "start_mcp_gateway.cjs", "gateway startup command must be emitted") |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
behaviors.mcp.config-path(aider) never emitted thestart_mcp_gateway.cjsinvocation, soawmg-mcpgnever started while AWF still tried to attach it toawf-netBehaviorDefinedEngine.RenderMCPConfignow falls back to the default MCP servers path so the gateway always startssmoke-aider.lock.ymlnow starts the gateway) and ran validation