Fix Crush engine failure by removing unsupported -y flag - #50436
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix smoke crush workflow failure due to engine termination
Fix Crush engine failure by removing unsupported Aug 5, 2026
-y flag
Collaborator
|
/smoke-crush |
Contributor
|
🚀 skillet has started processing this pull request comment |
Collaborator
|
@copilot add slash command /smoke-crush |
pelikhan
marked this pull request as ready for review
August 5, 2026 01:46
Copilot stopped work on behalf of
pelikhan due to an error
August 5, 2026 01:46
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Crush smoke workflow by removing the unsupported -y argument and synchronizing generated workflows.
Changes:
- Runs Crush as
crush run --quiet. - Regenerates the smoke workflow and centralized command routing.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/shared/crush.md |
Removes the invalid argument. |
.github/workflows/smoke-crush.lock.yml |
Updates compiled Crush invocations. |
.github/workflows/agentic_commands.yml |
Synchronizes /smoke-crush routing. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Smoke Crush workflow fails immediately with
Unknown shorthand flag: 'y' in -y.. The engine invokescrush -y run --quiet, but in@charmland/crush@0.88.0the--yolo/-yflag is registered only on the root command and is not persistent, so it is rejected once a subcommand is used.crush runis already non-interactive and does not prompt for permissions, so the flag serves no purpose.Changes
.github/workflows/shared/crush.md— drop-yfromengine.behaviors.execution.args..github/workflows/smoke-crush.lock.yml— regenerated viamake recompile.Verified against the CLI's own help output:
crush runexposes-C/-c/-D/-d/-h/-H/-m/-q/-s/--small-model/-v, with no-y.