Skip to content

Fixing crush configuration error - #50452

Merged
pelikhan merged 1 commit into
mainfrom
copilot/fix-crush-configuration-one-more-time
Aug 5, 2026
Merged

Fixing crush configuration error#50452
pelikhan merged 1 commit into
mainfrom
copilot/fix-crush-configuration-one-more-time

Conversation

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Pull request created by AI Agent

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan

pelikhan commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

/smoke-crush

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🎯 Smoke Crush Crush delivered.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection results could not be parsed.

Review the workflow run logs for details.

@pelikhan

pelikhan commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@copilot fix smoke-crush by allowing go in network
https://github.com/github/gh-aw/actions/runs/30969554457/job/92190890798

@pelikhan
pelikhan marked this pull request as ready for review August 5, 2026 02:37
Copilot AI balanced review requested due to automatic review settings August 5, 2026 02:37
@pelikhan
pelikhan merged commit 34983a7 into main Aug 5, 2026
7 of 8 checks passed
@pelikhan
pelikhan deleted the copilot/fix-crush-configuration-one-more-time branch August 5, 2026 02:37
Copilot stopped work on behalf of pelikhan due to an error August 5, 2026 02:38
Copilot AI requested a review from pelikhan August 5, 2026 02:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Crush execution to pass prompts as positional arguments instead of stdin.

Changes:

  • Adjusts the shared Crush harness invocation.
  • Regenerates the smoke-test workflow lock file.
Show a summary per file
File Description
.github/workflows/shared/crush.md Updates Crush prompt delivery.
.github/workflows/smoke-crush.lock.yml Reflects the regenerated workflow.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

const prompt = readFileSync(promptPath, "utf8");
fail(
spawnSync(command, [...commandArgs, "--model", `awf-proxy/${model}`], {
spawnSync(command, [...commandArgs, "--model", `awf-proxy/${model}`, prompt], {
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.85.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants