Remove stale token telemetry tracking link - #50458
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix awmg-mcpg container-attach race in Smoke Aider
Remove stale token telemetry tracking link
Aug 5, 2026
pelikhan
marked this pull request as ready for review
August 5, 2026 03:30
Copilot stopped reviewing on behalf of
pelikhan due to an error
August 5, 2026 03:30
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the generated gh-aw smoke-test workflow lockfiles to remove a token telemetry error message line that pointed to a specific tracking issue.
Changes:
- Removed the “See tracking issue: https://github.com/github/gh-aw/issues/42791” log line from the token telemetry checks across workflows.
- Regenerated workflow lock metadata (updated
frontmatter_hashvalues) accordingly. - Updated the shared token telemetry check snippet to match the new behavior.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-test-tools.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-temporary-id.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-service-ports.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-project.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-opencode.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-goose.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-gemini.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-cursor.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-crush.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-copilot.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-copilot-arm.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-copilot-aoai-entra.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-copilot-aoai-apikey.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-codex.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/smoke-claude.lock.yml | Removes tracking-issue echo from token telemetry check; regenerated lock metadata. |
| .github/workflows/shared/token-telemetry-check.md | Removes the tracking-issue line from the shared telemetry check snippet. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 16/16 changed files
- Comments generated: 2
- Review effort level: Lite
Comment on lines
40
to
44
| if [ "${FOUND_NONEMPTY}" != "true" ]; then | ||
| echo "::error::All token_usage.jsonl files are empty or missing after a successful agent run." | ||
| echo "::error::The AWF firewall proxy token telemetry emitter may be broken." | ||
| echo "::error::See tracking issue: https://github.com/github/gh-aw/issues/42791" | ||
| exit 1 | ||
| fi |
| # gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"fef4d3cd05c76ebe71c7ea3703d83446e561550acf3080cd88c53110a6abc18d","body_hash":"f1433701c1a4b4bd3891ad75341f667d76f624568fadfc5ca49b2bc4c1e0eb87","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.77"}} | ||
| # gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"07d4eb0752360c8c810d18bef38cd745040de4dd2fa0e0dca7b8bcc3e4be2dc9","body_hash":"f1433701c1a4b4bd3891ad75341f667d76f624568fadfc5ca49b2bc4c1e0eb87","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.77"}} | ||
| # gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GH_AW_OTEL_GRAFANA_AUTHORIZATION","GH_AW_OTEL_GRAFANA_ENDPOINT","GH_AW_OTEL_SENTRY_AUTHORIZATION","GH_AW_OTEL_SENTRY_ENDPOINT","GITHUB_TOKEN"],"actions":[{"repo":"actions/cache/restore","sha":"55cc8345863c7cc4c66a329aec7e433d2d1c52a9","version":"v6.1.0"},{"repo":"actions/cache/save","sha":"55cc8345863c7cc4c66a329aec7e433d2d1c52a9","version":"v6.1.0"},{"repo":"actions/checkout","sha":"3d3c42e5aac5ba805825da76410c181273ba90b1","version":"v7.0.1"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-dotnet","sha":"a98b56852c35b8e3190ac28c8c2271da59106c68","version":"v6.0.0"},{"repo":"actions/setup-go","sha":"b7ad1dad31e06c5925ef5d2fc7ad053ef454303e","version":"v7.0.0"},{"repo":"actions/setup-java","sha":"b6effb05e454b25005698d916606bdc6ffcbf961","version":"v5.7.0"},{"repo":"actions/setup-node","sha":"820762786026740c76f36085b0efc47a31fe5020","version":"v7.0.0"},{"repo":"actions/setup-python","sha":"5fda3b95a4ea91299a34e894583c3862153e4b97","version":"v7.0.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.43","digest":"sha256:04e2d1987a565000a8f114b89d806ae7a3864dd4f944be65275b28c93d8690e6","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.43@sha256:04e2d1987a565000a8f114b89d806ae7a3864dd4f944be65275b28c93d8690e6"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.43","digest":"sha256:d85f57975af5ea23af4996e41ed73fbc8f5b4a47402472bfe82e508f352cb0c1","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.43@sha256:d85f57975af5ea23af4996e41ed73fbc8f5b4a47402472bfe82e508f352cb0c1"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.43","digest":"sha256:26be5e0b8c8f4c41c8a59126b29bb5d80b07253597472ded2a16bdd75abcbf9d","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.43@sha256:26be5e0b8c8f4c41c8a59126b29bb5d80b07253597472ded2a16bdd75abcbf9d"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.4.7","digest":"sha256:7545220a9aca134b71e51193ee0eaf4c50756ebf8fbd25a63ae7556e62815c00","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.4.7@sha256:7545220a9aca134b71e51193ee0eaf4c50756ebf8fbd25a63ae7556e62815c00"},{"image":"ghcr.io/github/gh-aw-node","digest":"sha256:0d9f1fb5fd6610c0ac1f5194a38e45a8a1e81f8a390d5142d8e4e6f26a4b3196","pinned_image":"ghcr.io/github/gh-aw-node@sha256:0d9f1fb5fd6610c0ac1f5194a38e45a8a1e81f8a390d5142d8e4e6f26a4b3196"},{"image":"ghcr.io/github/github-mcp-server:v1.8.0","digest":"sha256:d5a18c04b92714c309eb46a2305087e91a4dbd80420f6e462656699f95093520","pinned_image":"ghcr.io/github/github-mcp-server:v1.8.0@sha256:d5a18c04b92714c309eb46a2305087e91a4dbd80420f6e462656699f95093520"}],"has_pull_request":true} | ||
| # This file was automatically generated by gh-aw. DO NOT EDIT. To debug this workflow, load the skill at https://github.com/github/gh-aw/blob/main/debug.md |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke Goose correctly detects missing token telemetry but reports a nonexistent tracking issue. The reported Smoke Aider MCP sidecar failure is already covered by gateway-rendering regression coverage.
Telemetry diagnostics
#42791reference while preserving the actionable failure messages.Generated workflows