[WIP] Fix smoke cursor workflow failure due to authentication issue - #50472
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
/smoke-cursor |
|
🚀 Smoke Cursor Cursor delivered. |
Cursor Smoke Test 30975573886
Overall: FAIL Run: https://github.com/github/gh-aw/actions/runs/30975573886 Warning Firewall blocked 3 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "proxy.golang.org"
- "registry.npmjs.org"
- "repo42.cursor.sh"See Network Configuration for more information.
|
There was a problem hiding this comment.
🟡 Not ready to approve
Auth credentials overridden through engine.env are still excluded from the sandbox.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Fixes declarative engine authentication by allowing required API keys into AWF sandboxes.
Changes:
- Exempts declarative auth bindings from sandbox exclusions.
- Adds regression coverage.
- Regenerates Cursor and Kiro workflows.
File summaries
| File | Description |
|---|---|
pkg/workflow/behavior_defined_engine.go |
Adjusts secret exclusions. |
pkg/workflow/behavior_defined_engine_harness_test.go |
Tests auth-secret passthrough. |
.github/workflows/smoke-cursor.lock.yml |
Regenerates Cursor workflow. |
.github/workflows/smoke-kiro.lock.yml |
Regenerates Kiro workflow. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| UsesTTY: false, | ||
| AllowedDomains: allowedDomains, | ||
| ExcludeEnvVarNames: ComputeAWFExcludeEnvVarNames(workflowData, e.GetRequiredSecretNames(workflowData)), | ||
| ExcludeEnvVarNames: ComputeAWFExcludeEnvVarNames(workflowData, excludedSecretNames), |
|
🎉 This pull request is included in a new release. Release: |
Uh oh!
There was an error while loading. Please reload this page.