Skip to content

[WIP] Fix smoke cursor workflow failure due to authentication issue - #50472

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-smoke-cursor-failure
Aug 5, 2026
Merged

[WIP] Fix smoke cursor workflow failure due to authentication issue#50472
pelikhan merged 2 commits into
mainfrom
copilot/aw-fix-smoke-cursor-failure

Conversation

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  • Inspect the failed workflow run and relevant Cursor workflow configuration
  • Preserve declarative-engine API keys in the sandbox and regenerate affected workflow output
  • Add focused regression coverage and run formatting, compilation, lint, impacted tests, secret scanning, and review
  • Run final CodeQL security scan and verify the committed diff

Copilot AI linked an issue Aug 5, 2026 that may be closed by this pull request
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan

pelikhan commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

/smoke-cursor

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Smoke Cursor Cursor delivered.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Cursor Smoke Test 30975573886

  • GitHub MCP: PASS
  • File Writing: PASS
  • Bash Tool: PASS
  • Build: FAIL (go 1.26.5 download Forbidden)

Overall: FAIL

Run: https://github.com/github/gh-aw/actions/runs/30975573886

Warning

Firewall blocked 3 domains

The following domains were blocked by the firewall during workflow execution:

  • proxy.golang.org
  • registry.npmjs.org
  • repo42.cursor.sh

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"
    - "registry.npmjs.org"
    - "repo42.cursor.sh"

See Network Configuration for more information.

🖱️ Smoke Cursor — Powered by Cursor ·
Comment /smoke-cursor to run again

@pelikhan
pelikhan marked this pull request as ready for review August 5, 2026 04:42
Copilot AI balanced review requested due to automatic review settings August 5, 2026 04:42
@pelikhan
pelikhan merged commit 0965245 into main Aug 5, 2026
7 of 8 checks passed
@pelikhan
pelikhan deleted the copilot/aw-fix-smoke-cursor-failure branch August 5, 2026 04:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

Auth credentials overridden through engine.env are still excluded from the sandbox.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Fixes declarative engine authentication by allowing required API keys into AWF sandboxes.

Changes:

  • Exempts declarative auth bindings from sandbox exclusions.
  • Adds regression coverage.
  • Regenerates Cursor and Kiro workflows.
File summaries
File Description
pkg/workflow/behavior_defined_engine.go Adjusts secret exclusions.
pkg/workflow/behavior_defined_engine_harness_test.go Tests auth-secret passthrough.
.github/workflows/smoke-cursor.lock.yml Regenerates Cursor workflow.
.github/workflows/smoke-kiro.lock.yml Regenerates Kiro workflow.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

UsesTTY: false,
AllowedDomains: allowedDomains,
ExcludeEnvVarNames: ComputeAWFExcludeEnvVarNames(workflowData, e.GetRequiredSecretNames(workflowData)),
ExcludeEnvVarNames: ComputeAWFExcludeEnvVarNames(workflowData, excludedSecretNames),
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.85.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Smoke Cursor failed

3 participants