[avenger] ## Fix prettier formatting in eslint-factory rules - #50574
Conversation
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Formats two long TypeScript string properties to satisfy Prettier without changing behavior.
Changes:
- Wraps the numeric-parse validation message.
- Wraps the structured-clone rule description.
Show a summary per file
| File | Description |
|---|---|
eslint-factory/src/rules/require-nan-check-after-env-numeric-parse.ts |
Formats the requireNaNCheck message. |
eslint-factory/src/rules/prefer-structured-clone.ts |
Formats the rule description. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the implementation label and has 0 new lines of code in business logic directories. |
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — no issues found. This is a pure Prettier formatting fix: two long string literals wrapped onto their own lines to satisfy the formatter. The changes are correct, minimal, and consistent with the project's formatting conventions.
✅ Approved — no actionable issues.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 13.6 AIC · ⌖ 7.72 AIC · ⊞ 7.1K
Comment /matt to run again
There was a problem hiding this comment.
Verdict: no blocking issues
This PR is a pure Prettier reformat: two long string literals (description and requireNaNCheck) are wrapped onto their own line via key: "value". No logic, control flow, or runtime behavior changes.
💡 Review notes
- Diff is a whitespace-only change confirmed by identical string content before/after.
- No new code paths, no test impact expected.
- Nothing in this diff warrants inline comments.
🔎 Code quality review by PR Code Quality Reviewer · auto · 8.84 AIC · ⌖ 3.64 AIC · ⊞ 7.9K
Comment /review to run again
|
🎉 This pull request is included in a new release. Release: |
Summary
CI on
mainwas failing due to unformatted TypeScript in two eslint-factory rule files introduced by the recent WIP commit (fb136c8). Prettier wanted the longdescription/requireNaNCheckstring properties wrapped onto their own lines.Fixes applied
eslint-factory/src/rules/prefer-structured-clone.ts— reformatted longdescriptionproperty.eslint-factory/src/rules/require-nan-check-after-env-numeric-parse.ts— reformatted longrequireNaNCheckmessage property.Verification
make fmt— code formatted successfully (only these 2 files changed).make update-wasm-golden—TestWasmGolden_AllEnginesPASS.make lint— JavaScript lint validated with 0 errors (73 pre-existing warnings unaffected).make test-unit— no impacted Go tests; changes are TS-only formatting.Environment note
The sandbox ships Go 1.25.12 while
go.modrequires 1.26.5; steps were run withGOTOOLCHAIN=autoto fetch the correct toolchain.golangci-lintis not installed in the sandbox, so the Go lint sub-step could not run, but no Go sources were modified.