Run Zizmor on all generated workflows in CI - #50641
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Zizmor to CI for gh aw project
Run Zizmor on all generated workflows in CI
Aug 5, 2026
pelikhan
reviewed
Aug 5, 2026
| GH_TOKEN: ${{ github.token }} | ||
|
|
||
| zizmor: | ||
| needs: [build] |
pelikhan
reviewed
Aug 5, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a CI job intended to scan all generated workflows with Zizmor using the existing build artifact.
Changes:
- Adds the
zizmorjob. - Connects it to failure notification aggregation.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds and wires the Zizmor CI scan. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Balanced
| run: chmod +x gh-aw | ||
|
|
||
| - name: Run zizmor security scan on all workflows | ||
| run: ./gh-aw compile --zizmor --verbose |
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
|
|
||
| zizmor: |
| - build | ||
| - build-wasm | ||
| - validate-yaml | ||
| - zizmor |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-aw generates GitHub Actions workflows, but CI only scanned a single workflow (
poem-bot) with Zizmor, and only onmain. This lets Zizmor findings ship in the generated.lock.ymlfiles, blocking gh-aw CLI upgrades for downstream projects (e.g. Argo CD) that run Zizmor on their own CI.Changes
zizmorjob in.github/workflows/cgo.yml— depends onbuild, restores the checkout cache, downloads the already-builtgh-aw-linux-amd64artifact (no rebuild), and runs./gh-aw compile --zizmor --verboseto scan all repository workflows on every CI event.notify-failureso failures surface through the existing aggregation.Unlike the pre-existing
security-scanmatrix (main-only, single workflow), this job covers every generated workflow on all events, catching findings before release.