Redact sensitive MCP data at logging and audit boundaries - #50775
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Redact MCP configuration and tool calls at logging boundary
Redact sensitive MCP data at logging and audit boundaries
Aug 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces sensitive-data exposure across MCP runtime logs, GraphQL errors, and audit storage.
Changes:
- Adds recursive sensitive-key redaction.
- Replaces payload logging with diagnostic metadata.
- Hardens audit permissions, retention, and filenames.
Show a summary per file
| File | Description |
|---|---|
safe_outputs_config_redact.cjs |
Expands secret-key detection. |
safe_outputs_config_redact.test.cjs |
Tests recursive redaction. |
mcp_cli_bridge.cjs |
Hardens runtime and audit logging. |
mcp_cli_bridge.test.cjs |
Tests metadata, permissions, and retention. |
github_api_helpers.cjs |
Omits GraphQL request/response data. |
github_api_helpers.test.cjs |
Tests GraphQL payload omission. |
convert_gateway_config_shared.cjs |
Stops logging converted configurations. |
convert_gateway_config_shared.test.cjs |
Verifies configuration secrets are not logged. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 8/8 changed files
- Comments generated: 2
- Review effort level: Balanced
| if (error.request) core.info(`Request: ${JSON.stringify(error.request, null, 2)}`); | ||
| if (error.data) core.info(`Response data: ${JSON.stringify(error.data, null, 2)}`); | ||
| if (error.request) core.info("Request details omitted"); | ||
| if (error.data) core.info("Response data omitted"); |
| statusCode: resp.statusCode, | ||
| elapsedMs, | ||
| response: resp.body, | ||
| responseBytes: serializedSize(resp.body), |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP runtime logging exposed configuration secrets, tool payloads, and API error details. Audit records also persisted raw arguments and responses with permissive file permissions.
Redaction
Runtime logging
Audit storage
0700directories and0600JSONL files.