fix: ensure blank line before footer in PR review body - #50863
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…kdown rendering Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
fix: ensure blank line before footer in PR review body for proper markdown rendering
fix: ensure blank line before footer in PR review body
Aug 6, 2026
Copilot created this pull request from a session on behalf of
pelikhan
August 6, 2026 12:36
View session
pelikhan
marked this pull request as ready for review
August 6, 2026 12:39
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes malformed PR review footer rendering by inserting a blank line before the generated blockquote.
Changes:
- Adds the required Markdown separator before review footers.
- Adds regression coverage for footer separation.
- Registers the designer mappings reference in the workflow skill.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/pr_review_buffer.cjs |
Separates review content from the footer. |
actions/setup/js/pr_review_buffer.test.cjs |
Tests correct Markdown separation. |
.github/skills/agentic-workflows/SKILL.md |
Lists the designer mappings reference. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr_review_buffer.cjsappended the footer blockquote (> Generated by...) directly to the review body without a\n\nseparator, causing the blockquote to render inline with preceding content (e.g.</details>> Generated by...).All other callers (
add_comment.cjs,close_entity_helpers.cjs,comment_memory.cjs,create_issue.cjs) already include the blank line — this was the only site missing it.body += "\n\n" + generateFooterWithMessages(...)inpr_review_buffer.cjs/\n\n> /Observed in #50806 (review).