[avenger] Fix prettier formatting in eslint-factory rule test - #50873
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Threat detection produced a warning for this pull request output.
These changes need to be scrutinized before merge and only merged after a careful manual review.
- Detection reason:
agent_failure - Review workflow run logs: https://github.com/github/gh-aw/actions/runs/31104060897
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories. |
|
✅ Test Quality Sentinel completed test quality analysis. Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. No test files were added or modified in this PR. Test Quality Sentinel skipped. |
|
✅ PR Code Quality Reviewer completed the code quality review. Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. PR #50873 is a trivial, mechanical prettier-formatting fix (whitespace-only reflow of a valid: [...] array in a single test file, +1/-4). No logic, correctness, security, or maintainability concerns; nothing actionable to review. No review comments or REQUEST_CHANGES needed. |
There was a problem hiding this comment.
Pull request overview
Reformats an ESLint rule test to restore Prettier compliance without changing behavior.
Changes:
- Condenses the
validtest array onto one line.
Show a summary per file
| File | Description |
|---|---|
eslint-factory/src/rules/require-fetch-response-body-try-catch.test.ts |
Applies Prettier formatting to valid test cases. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
There was a problem hiding this comment.
Warning
Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.
What happened
The threat detection engine failed to produce results.
Review the workflow run logs for details.
Skills-Based Review 🧠
Applied /tdd — no skill concerns on this change.
This is a pure prettier formatting fix: the valid: [...] array in the rule test was reformatted from multi-line to single-line to match the configured prettier style. No logic, semantics, or test coverage changed. The fix correctly unblocks CI.
✅ Approved.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 13.1 AIC · ⊞ 7.1K
Comment /matt to run again
|
🎉 This pull request is included in a new release. Release: |
Warning
Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.
What happened
The threat detection engine failed to produce results.
Review the workflow run logs for details.
Summary
Applies Prettier auto-formatting to a single test file in the eslint-factory package. No test logic or assertions were changed.
Changes
eslint-factory/src/rules/require-fetch-response-body-try-catch.test.tsvalidtest-case array in therequire-fetch-response-body-try-catchdescribe block from a multi-line array to a single inline line, per Prettier's formatting rules.Commits
fe95bd672— fix: apply prettier formatting to eslint-factory rule testNotes
Formatting-only change with no functional or behavioral impact.> Generated by PR Description Updater for #50873 · auto · 35 AIC · ⊞ 6.8K · ◷