[log] Add debug logging to run phase, update compile, trial types, and safe-outputs handler/data-schema code - #50993
Merged
Conversation
…-outputs data schema/handler registry Adds pkg:filename-namespaced loggers (workflow:run_phase, cli:update_compile, cli:trial_types, workflow:safe_outputs_data_schema, workflow:safe_outputs_handler_registry) with entry/state-change/decision log calls, following the conventions in AGENTS.md.
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
pkg/logger-based debug logging to 5 previously under-instrumented Go files, following the conventions in AGENTS.md (onelogger.New("pkg:filename")var per file, gated internally by the logger's own enabled check, no side-effecting log arguments).pkg/workflow/run_phase.goworkflow:run_phaseevals/detection) a workflow resolves topkg/cli/update_compile.gocli:update_compilepkg/cli/trial_types.gocli:trial_typespkg/workflow/safe_outputs_data_schema.goworkflow:safe_outputs_data_schemasafe-outputs.dataresolved (disabled / inline schema / GitHub Actions expression)pkg/workflow/safe_outputs_handler_registry.goworkflow:safe_outputs_handler_registryNo
_test.gofiles were modified. Exactly 5 files changed.Validation note
This sandbox has Go 1.25.12 installed with
GOTOOLCHAIN=local, whilego.modrequiresgo >= 1.26.5, somake buildandmake fmtcould not be run locally here (pre-existing environment gap, unrelated to this change). The real CI workflow for this job (.github/workflows/go-logger.lock.yml) setsGOTOOLCHAIN: autoand usesactions/setup-gopinned togo-version-file: go.mod, which installs the correct toolchain automatically, so CI build/format checks should validate this normally. The diffs were manually reviewed line-by-line for import correctness, naming collisions, and gofmt-style formatting (tabs, import grouping) matching existing sibling-file patterns in the same packages.