Address Persona Explorer findings: trigger ambiguity, digest grouping, compliance example - #52121
Merged
Merged
Conversation
…xample, digest grouping guidance, compliance example Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze agent persona findings and recommendations
Address Persona Explorer findings: trigger ambiguity, digest grouping, compliance example
Aug 11, 2026
pelikhan
marked this pull request as ready for review
August 11, 2026 18:12
Contributor
There was a problem hiding this comment.
Pull request overview
Adds clearer workflow guidance for coordination triggers, recurring digest grouping, and license compliance evidence.
Changes:
- Defines milestone/dependency trigger decisions and digest deduplication guidance.
- Adds a dependency-license compliance example.
- Unexpectedly replaces the slide deck with an LFS pointer.
Show a summary per file
| File | Description |
|---|---|
.github/aw/create-agentic-workflow-trigger-details.md |
Adds coordination trigger guidance. |
.github/aw/report.md |
Requires grouping and deduplication with report windows. |
.github/aw/github-agentic-workflows.md |
Adds the compliance workflow example. |
docs/slides/index.md |
Replaces slide content with an unrelated LFS pointer. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 4
- Review effort level: Balanced
Comment on lines
+1
to
+3
| version https://git-lfs.github.com/spec/v1 | ||
| oid sha256:6dff7f23b04f978e62d3477279efb1ff7712e51495f0c54f3616daef510c2574 | ||
| size 10889 |
| | Signal in the request | Trigger | Grouping dimension | Dedup key example | | ||
| |---|---|---|---| | ||
| | "weekly/daily view of milestones at risk" | `schedule` + `workflow_dispatch` | milestone, owning team | `milestone-risk:<milestone>:<window-id>` | | ||
| | "let me know the moment a milestone slips" | `issues` (`milestoned`/`demilestoned`) or `workflow_run` if computed by CI | milestone | `milestone-slip:<milestone>:<issue-number>` | |
Comment on lines
+142
to
+149
| paths: | ||
| - "package.json" | ||
| - "package-lock.json" | ||
| - "go.mod" | ||
| - "requirements.txt" | ||
| - "Cargo.toml" | ||
| - "pyproject.toml" | ||
| - "composer.json" |
| Prompt guidance: | ||
|
|
||
| 1. **Scope**: only inspect dependency manifest/lockfile diffs in this PR; `noop` immediately if none changed. | ||
| 2. **Evidence, not assumption**: for each newly added or upgraded dependency, look up its declared license from the manifest/lockfile metadata or the package registry — never guess a license from the package name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Agent Persona Explorer run flagged trigger ambiguity in coordination-style scenarios, inconsistent grouping-dimension guidance for recurring digests, and a missing compliance example covering manifest-path scoping with license-evidence validation.
Trigger decision guidance
create-agentic-workflow-trigger-details.mdwith an explicit decision order betweenschedule(ongoing digest) and event-drivenissuestriggers, plus a signal-to-trigger mapping table and dedup-key examples.Recurring digest consistency
report.mdso grouping dimensions and a deduplication key are required alongside the report window whenever a window is defined, rather than treating the window as sufficient on its own.Compliance example
github-agentic-workflows.md, with a frontmatter snippet scopingpull_request.pathsto dependency manifests/lockfiles and prompt guidance requiring license evidence (registry metadata,LICENSEfile, or SPDX identifier) before tier classification and escalation.All changes are documentation-only, scoped to agent guidance files under
.github/aw/.